Hixie (not reading bugmail) Reporter
	Description • 16 years ago

window.directories in Gecko returns the same [BarProp] object as window.personalbar. No other browser supports it. Unless support for this is needed, we should drop it. If support is needed, please let me know so I can add it to the spec.

	Johnny Stenback (:jst)
	Comment 3 • 14 years ago

Comment on attachment 432352 [details] [diff] [review]
Fix with new uuid

Stealing review. r=jst

	Dão Gottwald [:dao]
	Comment 4 • 14 years ago

What about dom.disable_window_open_feature.directories?

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 5 • 14 years ago

(In reply to comment #4)
> What about dom.disable_window_open_feature.directories?

Something else entirely, it's related to window.open(). Hixie actually wants to drop all support for the features argument, so I'd rather not spend time on it.

(Note: Used in <http://mxr.mozilla.org/mozilla-central/source/embedding/components/windowwatcher/src/nsWindowWatcher.cpp#1501>.)

	Dão Gottwald [:dao]
	Comment 6 • 14 years ago

(In reply to comment #5)
> (In reply to comment #4)
> > What about dom.disable_window_open_feature.directories?
> 
> Something else entirely, it's related to window.open().

So is window.directories, except that it exposes the state while the directories argument allows setting it. directories=... duplicates personalbar=... just like window.directories duplicates window.personalbar. Keeping both things in sync in seems only logical, regardless of any future plans to drop all feature arguments.

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 7 • 14 years ago

Fair enough.

	Dão Gottwald [:dao]
	Comment 8 • 14 years ago

Comment on attachment 445103 [details] [diff] [review]
Remove argument to window.open and pref

Don't think my feedback is needed here beyond what I said in my previous comment...

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 9 • 14 years ago

Merged to tip. r=jst.

	Marco Bonardo [:mak] (Away Apr 25 - May 5)
	Comment 10 • 14 years ago

does not apply cleanly here, can you provide an updated patch please?

	Dão Gottwald [:dao]
	Comment 11 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/e0a9a9ea63f1

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 12 • 14 years ago

I added a note to <https://developer.mozilla.org/en/Upcoming_Firefox_features_for_developers#Miscellaneous_DOM_changes> and removed it from <https://developer.mozilla.org/en/DOM%3awindow.open>. Is any more documentation needed?

	Dão Gottwald [:dao]
	Comment 13 • 14 years ago

https://developer.mozilla.org/en/DOM%3awindow.open used to say:

"directories: [...] in MSIE 5+, it renders the Links bar. [...] personalbar: Same as directories but only supported by Netscape and Mozilla-based browsers."

Was that incorrect?

	j.j.
	Comment 14 • 14 years ago

You should not remove information from MDC as long as older browser versions are in use. People may use obsolete features or search for info why it doesn't work.
  
I propose:

https://developer.mozilla.org/en/DOM/window#Properties
Add an obsolete-inline template

https://developer.mozilla.org/En/DOM/Window.directories
Add an obsolete-header template,
mention the Gecko/Firefox version which dropped it,
recommend use of "window.personalbar" instead,
(perhaps link to this bug if you think it's helpful).

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 15 • 14 years ago

Apparently IE doesn't support any of the BarProp objects, but up to IE6, it did support the directories feature to window.open. (See also <http://msdn.microsoft.com/en-us/library/ms536651%28VS.85%29.aspx>.) (WebKit seems to ignore the features, and support only the personalbar object. Opera seems to support neither the features nor any BarProp objects.)

Made changes to
https://developer.mozilla.org/en/DOM/window.open
https://developer.mozilla.org/en/DOM/window#Properties
https://developer.mozilla.org/En/DOM/Window.directories