Vitaly Harisov Reporter
	Description • 18 years ago

-moz-box-sizing: border-box is applied to generic block-level element, but isn't applied to table cell. See test-case.

Tested on:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060505 Firefox/1.5.0.3

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3

	Tal Aloni Assignee
	Comment 5 • 12 years ago

Hi,
I've already took care of table cell height in bug 248239,
This one on the other hand is a feature.

The attached patch does not do anything different unless -moz-box-sizing is set to border-box or padding-box.

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 12 • 12 years ago

Comment on attachment 638476 [details] [diff] [review]
Table Cell Width Patch - v1

># User Tal Aloni <tal.aloni.il@gmail.com>
>honor -moz-box-sizing in standards mode (we ignore it in quirks mode). bug 338554

put "on table cells" somewhere in this sentence

>+        // In quirks mode, table cell width should be content-box,
>+        // but height should be border box.
>+        // because of this historic anomaly, we do not use quirk.css
>+        // (we can't speficy one value of box-sizing for width and another
>+        // for height)
>+        // For this reason, we also do not use box-sizing for just one of them,
>+        // as this may be confusing.

speficy -> specify

Also, could you format this comment a bit more neatly, capitalize "because" and put a "." at the end of that sentence, capitalize "we" and again put a "." at the end of the sentence, and wrap the entire comment at somewhere between 72 and 78 characters

r=dbaron with that; sorry for the delay getting to this

	j.j.
	Comment 13 • 12 years ago

Note:  https://developer.mozilla.org/en/CSS/Box-sizing
has a hint to this bug, needs an update

	Tal Aloni Assignee
	Comment 15 • 12 years ago

Hi,
Since I don't have permissions to add the "checkin-needed" keyword, I would appreciate if someone would add it for me.

checkin-buddy, I've learned to use hg just for you!

Thanks!
Tal

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0f359a74772

And somebody please give the man editbugs privs! Also, Tal, please follow the directions below for future patches you submit. It makes life easier for those committing on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Also, should this have reftests?

	Tal Aloni Assignee
	Comment 17 • 12 years ago

(In reply to Ryan VanderMeulen from comment #16)
> Tal, please follow the directions below for future patches you submit. It makes
> life easier for those committing on your behalf.
> https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Thanks Ryan, sorry for the trouble!
This time I used TortoiseHG instead of WinMerge, so I'm making some progress.
To be honest I've had a hard time to understand from this page what's needed to be done, though perhaps I've given up too quickly.

> should this have reftests?
it does, I previously tweaked one test to have -moz-box-sizing:border-box, and other tests use the default content-box.
(There are no tests for padding-box, but that's not an official CSS property)

	j.j.
	Comment 18 • 12 years ago

So this introduces a new quirks mode difference, since "box-sizing" applies to table cells in standards mode only, right?

	Tal Aloni Assignee
	Comment 19 • 12 years ago

(In reply to j.j. (inactive in 2012) from comment #18)
> "box-sizing" applies to table cells in standards mode only, right?
Yes.

> So this introduces a new quirks mode difference
quirks mode will continue to behave as it did, its behavior was not modified in any way.

However, if you specifically set -moz-box-sizing:border-box, then yes, it will not apply to quirks mode, but will apply to standards mode.

	Ed Morley [:emorley]
	Comment 20 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/f0f359a74772

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 21 • 12 years ago

(In reply to Ryan VanderMeulen from comment #16)
> And somebody please give the man editbugs privs!

Done.  See https://developer.mozilla.org/en/What_to_do_and_what_not_to_do_in_Bugzilla

(In reply to Tal Aloni from comment #17)
> (In reply to Ryan VanderMeulen from comment #16)
> > should this have reftests?
> it does, I previously tweaked one test to have -moz-box-sizing:border-box,
> and other tests use the default content-box.
> (There are no tests for padding-box, but that's not an official CSS property)

I don't see this in the patch.  Which test?

	Tal Aloni Assignee
	Comment 22 • 12 years ago

(In reply to David Baron [:dbaron] from comment #21)
> I don't see this in the patch.  Which test?
494667-2.html
incidentally, it now doubles as a test for border-box sizing, I already had to switch it to border-box in my previous patch because the original reftest violated the css specs, and now I fixed the width.

	Jean-Yves Perrier [:teoli]
	Comment 23 • 12 years ago

I mentioned it on:
https://developer-new.mozilla.org/en-US/docs/Firefox_16_for_developers
and on
https://developer-new.mozilla.org/en-US/docs/CSS/box-sizing (though this one may be obsolete once we unprefix).

	voracity
	Comment 24 • 12 years ago

I think the fix for this is causing a wrapping problem in shrink-to-fit tables. (Or perhaps it's meant to work this way, but I hope not.)

In the attachment, the words are wrapped when I would not expect them to be.

	Tal Aloni Assignee
	Comment 25 • 12 years ago

Voracity,
I can confirm the issue you are seeing with the newly implemented "box-sizing:border-box".
The wrapping behavior should indeed be similar to "content-box", I am currently trying to figure this out.

	j.j.
	Comment 26 • 12 years ago

Please open a new bug if there are regressions.

	Tal Aloni Assignee
	Comment 27 • 12 years ago

voracity, The issue you reported is now bug 778413, patch is coming soon.