Closed Bug 1900195 Opened 10 months ago Closed 10 months ago

Remove support for the 'align-tracks' and 'justify-tracks' properties (css-grid-3)

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [anchorpositioning:m1])

Attachments

(1 file)

The CSS WG resolved to remove the 'align-tracks' and 'justify-tracks' properties:

https://github.com/w3c/csswg-drafts/pull/9529

I'd like to do this now because in https://phabricator.services.mozilla.com/D212335#7288874 I'll otherwise cause nsStylePosition to exceed the memory limit.

These properties were added as part of the experimental Masonry support added
in bug 1607954. Since then the CSS WG resolved to remove these properties in:
https://github.com/w3c/csswg-drafts/pull/9529

This patch is a fairly brain dead removal of the properties, simply changing
the consumer code to take the code paths that would have been taken previously
if the properties were not set. That leaves some obvious dead code, which has
been removed, but no attempt has been made to redesign the Masonry code to
"make sense" without these properties. That would require a more prolonged
effort to understand Masonry, how the spec has changed in the last four years,
and how we should best change our code.

For now, this removal is simply focused on reducing the amount of memory used
by nsStyleDisplay to unblock the landing of bug 1899949.

Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/41f4c3dbf5cf Remove support for the 'align-tracks' and 'justify-tracks' properties. r=emilio
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Keywords: dev-doc-needed

Related pull requests

Whiteboard: [anchorpositioning:m1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: