Closed Bug 1884647 Opened 2 months ago Closed 2 months ago

Fix partitioning in cookie commands

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
3

Tracking

(firefox125 fixed)

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 1884647 - [bidi] Fix partitioning in cookie commands.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1884647 - [wdpspec] Add more tests for partitioning.
48 bytes, text/x-phabricator-request
Details | Review

Looking at the Puppeteer test failures for cookie related APIs, I've noticed two things which are probably wrong:

  • when setting a same-site cookie with storage.setCookie command, we probably shouldn't add the partionKey in the originAttributes, otherwise cookies will not be available via document.cookie (and they probably should);
  • For the browsing context where we have one page loaded, but we try to set a cookie with storage.setCookie on a different domain, we should be able to retrieve it with storage.getCookies for this context, but for this we shouldn't limit the lookup only for the hostname from this browsing context.

(In reply to Alexandra Borovova [:Sasha] from comment #0)

Looking at the Puppeteer test failures for cookie related APIs, I've noticed two things which are probably wrong:

  • when setting a same-site cookie with storage.setCookie command, we probably shouldn't add the partionKey in the originAttributes, otherwise cookies will not be available via document.cookie (and they probably should);

It appeared that the fact that cookies with set partionKey in the originAttributes are not available with document.cookie is probably a bug on the platform side, see bug1884648. So this issue is excluded from this bug.

Points: --- → 3
Priority: -- → P1
Whiteboard: [webdriver:m10]
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d377406231e1
[bidi] Fix partitioning in cookie commands. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/056ff7828670
[wdpspec] Add more tests for partitioning. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45128 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m10] → [webdriver:m10], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/d377406231e1
https://hg.mozilla.org/mozilla-central/rev/056ff7828670

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m10], [wptsync upstream] → [webdriver:m10][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: