Closed
Bug 1884072
Opened 2 months ago
Closed 2 months ago
Make getStyleSheetRuleCountAndAtRules faster.
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox125 fixed)
RESOLVED
FIXED
125 Branch
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•2 months ago
|
||
We were returning the whole list of rules for a given stylesheet, and then
picking the at-rules we wanted in JS.
This patch make it so that the InspectorUtils method will only return the
at-rules we want directly, so we're building a smaller array of rule in the end.
Since getStyleSheetRuleCountAndAtRules also need to return the total number
of rules, this adds a simple InspectorUtils.getStyleSheetRulesCount method that
does that.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae42893523cc [devtools] Make `getStyleSheetRuleCountAndAtRules` faster. r=layout-reviewers,devtools-reviewers,emilio,ochameau.
|
||
Comment 3•2 months ago
|
||
Backed out for causing dt failures in browser_resources_stylesheets.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | devtools/shared/commands/resource/tests/browser_resources_stylesheets.js | Found a matching expected resource for the resource -
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f30bd08be61 [devtools] Make `getStyleSheetRuleCountAndAtRules` faster. r=layout-reviewers,devtools-reviewers,emilio,ochameau.
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
|
|
Assignee | |
Updated•2 months ago
|
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 6•2 months ago
|
||
== Change summary for alert #41836 (as of Sat, 16 Mar 2024 08:56:10 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 20% | damp custom.styleeditor.open.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 776.23 -> 622.99 |
| 19% | damp custom.styleeditor.open.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 749.16 -> 605.85 |
| 16% | damp custom.styleeditor.open.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 659.13 -> 554.51 |
| 16% | damp custom.styleeditor.open.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 652.79 -> 549.29 |
| 13% | damp custom.styleeditor.reload.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 416.99 -> 363.75 |
| ... | ... | ... | ... | ... |
| 8% | damp custom.styleeditor.close.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 11.89 -> 10.91 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41836
You need to log in
before you can comment on or make changes to this bug.
Description
•