Closed Bug 1882741 Opened 3 months ago Closed 3 months ago

[Inactive CSS] Do not show a warning when align-content is used on block containers

Categories

(DevTools :: Inspector: Rules, defect, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox125 fixed, firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed
firefox126 --- fixed

People

(Reporter: sebo, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=#devtools-reviewers.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=#devtools-reviewers.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

Bug 1684236 added support for align-content on block containers. This is currently behind the pref layout.css.align-content.blocks.enabled.

Therefore, we should not warn anymore when using align-content in this context if the pref is enabled.

Sebastian

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Thanks for providing a patch, Nicolas! Actually, I wanted to work on it today, though you were a little faster. :-)

Sebastian

Severity: -- → S3
Type: enhancement → defect
Priority: -- → P2
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44ee710d3a49
[devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau.

https://hg.mozilla.org/mozilla-central/rev/44ee710d3a49

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Attachment #9392507 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • User impact if declined: DevTools Inspector could indicate that a property (align-content) has no effect although it does
  • Risk associated with taking this patch: low
  • Is Android affected?: no
  • Needs manual QE test: no
  • String changes made/needed: inactive-css-not-grid-or-flex-or-block-container-fix was added in this patch
  • Code covered by automated testing: yes
  • Explanation of risk level: devtools-only , covered in test
  • Fix verified in Nightly: no
  • Steps to reproduce for manual QE testing: -

This patch adds a new string. Any concerns with taking this uplift into 125.0b3?

Flags: needinfo?(bolsson)

Sorry for the delay.
Considering the content and visibility of the string in question, I don't have a concern with uplifting the single string.

Flags: needinfo?(bolsson)
Attachment #9392507 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: