Add support for "contexts" argument to "network.addIntercept" command
Categories
(Remote Protocol :: WebDriver BiDi, enhancement, P2)
Tracking
(firefox126 fixed)
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: whimboo, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])
Attachments
(2 files)
The network.addIntercept command should support the context argument so that intercepts can be set to specific top-level browsing contexts only.
This feature got recently added via https://github.com/w3c/webdriver-bidi/pull/653/.
Tests are written upstream and will be synced via bug 1881005.
|
Reporter | |
Updated•3 months ago
|
|
|
Reporter | |
Comment 1•3 months ago
|
||
After talking to Puppeteer folks this is actually a missing feature that is highly wanted. If more than one open tab is used users will face issues. For details see https://github.com/puppeteer/puppeteer/pull/12106.
Julian, do you think that you could prioritize this bug? I think that we can move others over to M11.
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
|
|
Assignee | |
Comment 3•3 months ago
|
||
Depends on D205459
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ab10edbb899 [bidi] Add support for contexts argument to network.addIntercept command r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/6794b17b50ec [wdspec] Add test for addIntercept contexts argument with frames r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45309 for changes under testing/web-platform/tests
Backed out for causing failures on contexts.py
|
|
Assignee | |
Comment 7•3 months ago
|
||
It seems that on asan builds the requests take too long to be aborted and result in a test timeout.
|
|
Assignee | |
Comment 8•3 months ago
|
||
I will change the tests to assert the network events instead of waiting for the timeouts, this should be much faster on all platforms.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5bbb76c68bf8 [bidi] Add support for contexts argument to network.addIntercept command r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/e02aed8fb198 [wdspec] Add test for addIntercept contexts argument with frames r=webdriver-reviewers,Sasha
|
||
Comment 10•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5bbb76c68bf8
https://hg.mozilla.org/mozilla-central/rev/e02aed8fb198
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot
|
|
Reporter | |
Updated•1 month ago
|
Description
•