Add "userContext" field to "browsingContext.Info" type
Categories
(Remote Protocol :: WebDriver BiDi, task, P2)
Tracking
(firefox124 fixed)
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs, )
Details
(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])
Attachments
(5 files)
The PR adding support for user contexts also adds a new userContext field to browsingContext.Info, which is used for the payload of various events and commands of the browsingContext module.
|
||
Updated•4 months ago
|
|
Assignee | |
Comment 1•4 months ago
•
|
||
At the moment, the main way to retrieve the userContext for a BrowsingContext is to check the usercontextid attribute on the embedderElement. While this is fine for browsingContext.contextCreated and browsingContext.getTree, it won't work for browsingContext.contextDestroyed because the embedder element will no longer be defined on a deleted browsing context.
Either we can get the information to be stored on the browsing context or we will need to do something similar to what we did for navigable ids in Bug 1694390, ie keep track of a map between navigables and user context ids.
|
|
Assignee | |
Comment 2•4 months ago
|
||
Olli, do you know if we could have the user context id information directly set on the browsing context, to avoid reading it from the embedderElement?
|
|
Assignee | |
Updated•4 months ago
|
|
||
Comment 3•4 months ago
|
||
Where do we need this information? Can we get it from WindowGlobal's principal?
|
|
Assignee | |
Comment 4•4 months ago
|
||
(In reply to Olli Pettay [:smaug][bugs@pettay.fi] from comment #3)
Where do we need this information? Can we get it from WindowGlobal's principal?
From the parent process, but you're right this is available on the principal and this seems to work fine even when destroying the context. Thanks for the pointer!
|
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Comment 5•3 months ago
|
||
Depends on D200023
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 6•3 months ago
|
||
Depends on D200028
|
|
Assignee | |
Comment 7•3 months ago
|
||
Depends on D200032
This should ensure good coverage of the user_context field
|
|
Assignee | |
Comment 8•3 months ago
|
||
Depends on D200181
|
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 9•3 months ago
|
||
Depends on D200182
|
||
Comment 10•3 months ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab9c141ac485 [bidi] Add userContext field to browsingContext.Info r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/0237b0c99f39 [wdspec] Add type hint parameter for context_created and context_destroyed user context tests r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/8a66a3b89c40 [wdspec] Always assert user context in assert_browsing_context r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/1c00d395406f [wdspec] Add various user_context tests for browsingContext.create r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/246fa8615ed5 [bidi] Avoid using internal user context id in bidi modules r=webdriver-reviewers,whimboo
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44418 for changes under testing/web-platform/tests
|
||
Updated•3 months ago
|
|
||
Comment 13•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab9c141ac485
https://hg.mozilla.org/mozilla-central/rev/0237b0c99f39
https://hg.mozilla.org/mozilla-central/rev/8a66a3b89c40
https://hg.mozilla.org/mozilla-central/rev/1c00d395406f
https://hg.mozilla.org/mozilla-central/rev/246fa8615ed5
Upstream PR merged
|
|
||
Comment 15•3 months ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24ad3719a4b9 [wpt PR 44418] - [Gecko Bug 1874920] [wdspec] Add type hint parameter for context_created and context_destroyed user context tests, a=testonly
|
||
Comment 16•3 months ago
|
||
| bugherder | ||
|
|
||
Updated•2 months ago
|
Description
•