Inappropriate "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction", and "script.disown"
Categories
(Remote Protocol :: WebDriver BiDi, defect, P2)
Tracking
(firefox123 fixed)
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: Sasha, Assigned: Sasha)
References
()
Details
(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])
Attachments
(3 files)
In the initial implementation (see bug1779231), we assumed that specification of "script.evaluate", "script.callFunction", and "script.disown" (see this spec issue) should move into the direction of allowing to have only one type of argument based on the fields and added the assertion to not allow "context" and "realm" fields at the same time. But the spec was not changed that way, and now it causes an issue for a Puppeteer user: https://github.com/puppeteer/puppeteer/issues/11653, so in the scope of this bug we should align the implementation with the spec, meaning do not throw the error and ignore a "realm" argument if a "context" argument is provided.
|
Assignee | |
Updated•4 months ago
|
|
||
Updated•4 months ago
|
|
|
Assignee | |
Comment 1•4 months ago
|
||
|
||
Updated•4 months ago
|
|
|
Assignee | |
Comment 2•4 months ago
|
||
Depends on D198151
|
|
Assignee | |
Comment 3•4 months ago
|
||
Depends on D198152
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48568433ace2 [bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/56de1e8849a1 [wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/1cd3cffeda1b [wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
|
|
Assignee | |
Updated•4 months ago
|
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43923 for changes under testing/web-platform/tests
|
||
Updated•4 months ago
|
|
||
Comment 6•4 months ago
|
||
Backed out for causing puppeteer failures in evaluation.spec.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-PASS | Evaluation specs Page.evaluate should work from-inside an exposed function (evaluation.spec.js) | expected FAIL
Upstream PR was closed without merging
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0e34106490a [bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/743d6c09f4d7 [wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/7a6e6415fd6b [wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
|
|
Assignee | |
Comment 9•4 months ago
|
||
The test expectation data for puppeteer is updated, so the failure should be gone now.
|
||
Comment 10•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d0e34106490a
https://hg.mozilla.org/mozilla-central/rev/743d6c09f4d7
https://hg.mozilla.org/mozilla-central/rev/7a6e6415fd6b
Upstream PR merged by moz-wptsync-bot
|
|
||
Updated•2 months ago
|
Description
•