Serialization of WindowProxy fails for out-of-process iframes
Categories
(Remote Protocol :: WebDriver BiDi, defect, P1)
Tracking
(firefox122 fixed)
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m9][webdriver:relnote])
Attachments
(2 files)
As seen on https://github.com/w3c/webdriver-bidi/issues/418 we currently fail to correctly serialize the .contentWindow property of an OOP iframe. Due to that we return a plain object but not a WindowProxy remote value.
As example you can use that page to create an iframe with a cross-origin URL:
https://mathiasbynens.github.io/css-dbg-stories/iframe-navigations.html
When trying to serialize window.frames[0] an object is returned because we only check the class name. But given that this is a magic object this fails. Instead we need to run a check with Window.isInstance(value) to properly run this check here:
Sasha, would you mind to take that? It's needed so that we can get rid of the Fission related preferences from Puppeteer for BiDi.
|
Assignee | |
Updated•5 months ago
|
|
|
Assignee | |
Comment 1•5 months ago
|
||
|
|
Assignee | |
Comment 2•5 months ago
|
||
Depends on D195210
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f716db0179c3 [bidi] Use correct check to identify WindowProxy in the serialization. r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/ee79c48e48ea [wdspec] Add test cases for serialization of cross-origin iframes. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43477 for changes under testing/web-platform/tests
|
||
Comment 5•5 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f716db0179c3
https://hg.mozilla.org/mozilla-central/rev/ee79c48e48ea
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•5 months ago
|
|
Reporter | |
Updated•3 months ago
|
Description
•