Closed Bug 1861466 Opened 6 months ago Closed 4 months ago

Implement CustomStateSet

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: mozilla, Assigned: mozilla)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Bug 1861466 - Add CustomStateSet and :state() pseudo. r=emilio,smaug,canadahonk
48 bytes, text/x-phabricator-request
Details | Review
wpt_customelementtest_121.0a1.png
129.24 KB, image/png
hamishwillee
: feedback-
Details

Steps to reproduce:

Tracking issue for https://wicg.github.io/custom-state-pseudo-class/#customstateset

Assignee: nobody → keithamus
Attachment #9360453 - Attachment description: WIP: Bug 1861466 - A very early WIP of CustomStateSet → Bug 1861466 - Add CustomStateSet and :state() psuedo. r=emilio,smaug,canadahonk
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9360453 - Attachment description: Bug 1861466 - Add CustomStateSet and :state() psuedo. r=emilio,smaug,canadahonk → Bug 1861466 - Add CustomStateSet and :state() pseudo. r=emilio,smaug,canadahonk
Blocks: 1588763
Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
Version: Firefox 118 → unspecified
Pushed by mozilla@keithcirkel.co.uk:
https://hg.mozilla.org/integration/autoland/rev/ae536a17c1ff
Add CustomStateSet and :state() pseudo. r=emilio,smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43022 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/ae536a17c1ff

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Upstream PR merged by moz-wptsync-bot

Just tried this in FF Nightly 121.0a1 with the pref enabled. WPT test does not appear to pass - i.e. as you can see the "I should be green/blue" text is not appropriately coloured. Should this work? This is for MDN docs work.

Flags: needinfo?(mozilla)
Attachment #9364399 - Flags: feedback-

FF121 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/30339

Style invalidation still needs some work so changes aren’t always reflected - and is why WPT fails. I’ll be following up with more patches for this.

Flags: needinfo?(mozilla)

Thanks @Keith,

I was wondering if you might confirm something for me:

  1. You can only use this feature with autonomous custom elements (only custom elements that don't derive from built-ins). I tried doing a built in and got a DOMException as described here: https://github.com/whatwg/html/issues/5166

I have set dev-doc-complete - the docs are done on the assumption that the comments above are correct.

Keywords: dev-doc-needed → dev-doc-complete

(In reply to Hamish Willee from comment #9)

Thanks @Keith,

I was wondering if you might confirm something for me:

  1. You can only use this feature with autonomous custom elements (only custom elements that don't derive from built-ins). I tried doing a built in and got a DOMException as described here: https://github.com/whatwg/html/issues/5166

This is my understanding. I believe the docs are already complete, yes.

There are errors with WPT as work still needs to be done to complete this feature.

(To clarify this bug was for CustomStateSet IDL, but the parent issue #1588763 is still open)

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I don't know how I set this to reopened but this one should be marked fixed (I can no longer do so)

Status: REOPENED → RESOLVED
Closed: 6 months ago → 4 months ago
Resolution: --- → FIXED
Keywords: meta
Summary: [Tracking] Implement CustomStateSet → Implement CustomStateSet
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: