Closed Bug 1855763 Opened 7 months ago Closed 6 months ago

Remove '-moz-transform' (to avoid web compat issues when supporting 'zoom')

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: zcorpan, Assigned: emilio)

References

(Regressed 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files, 1 obsolete file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=390936#c104

This should probably be a pref so it's possible to test with and without support for -moz-transform and so it's easy to change direction if it turns out it's less bad to support -moz-transform.

It's already a pref (layout.css.prefixes.transforms)

OK nice! Then this bug is about flipping the default value.

This probably needs a couple test fixes.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

We want to disable prefixed transforms to see if it's feasible to ship
zoom without them.

Make tests use un-prefixed transforms.

For reference I used the following sed / grep combination for most of the changes above:

function replace() {                                                                                                                                                                                                                                                                                                   
  echo "replacing $1 to $2"
  rg -l "$1" | xargs sed -i -E -e s/"$1"/"$2"/g
}
replace '\-moz-perspective-origin:' 'perspective-origin:'
replace '\-moz-transform:' 'transform:'
# etc
Attachment #9356084 - Attachment description: Bug 1855763 - Use unprefixed transforms in tests. r=#layout,#style → Bug 1855763 - Automatic fixes to avoid using prefixed transforms in tests. r=#layout
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9e0c6f82d15
Automatic fixes to avoid using prefixed transforms in tests. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/81279ad55cef
Use another alias other than moz-transform to test use counters, and other manual fix-ups. r=layout-reviewers,jfkthame
Keywords: leave-open
Keywords: dev-doc-needed

The severity field is not set for this bug.
:dshin, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(dshin)
Severity: -- → S3
Flags: needinfo?(dshin)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/facd9f92e1f5
Disable -moz-transform and enable zoom on Nightly. r=zcorpan
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/793a305aa062
Disable -moz-transform and enable zoom on Nightly. r=zcorpan
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/a0041460ad93
Fix property_database.js to account for transform prefixes.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/10dec6063e0e
Add zoom entry to property_database.js
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Regressions: 1860258
Regressions: 1860424
Regressions: 1861730
Regressions: 1861726

Code like the one from comment 7 seems reasonable. Let's try to disable
prefixed transitions along with prefixed transforms in order to minimize
the compat fallout from CSS zoom.

While I was at it I also fixed the prefixed animation entries in the
property database and crashtests. But those aliases remain enabled.

Regressions: 1861828

(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)

Created attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Was this patch supposed to be for bug 1861730?

Flags: needinfo?(emilio)

Comment on attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Revision D192129 was moved to bug 1861730. Setting attachment 9360757 [details] to obsolete.

Attachment #9360757 - Attachment is obsolete: true

Yeah, thanks!

Flags: needinfo?(emilio)

Docs changes for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/29785

Regressions: 1864970
Regressions: 1865332
Regressions: 1875473
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: