Show more bookmarks button overlaps other buttons if placed on toolbar and browser has reduced width
Categories
(Firefox :: Theme, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | wontfix |
| firefox117 | --- | wontfix |
| firefox118 | --- | wontfix |
| firefox119 | --- | verified |
People
(Reporter: atrif, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
overlap.gif
Found in
- 118.0a1 (2023-08-27)
Affected versions
- 118.0a1 (2023-08-27)
- 117.0
- 115.2.0esr
Tested platforms
- Affected platforms: Ubuntu 20, Windows 10x64, macOS 12
- Unaffected platforms: none
Preconditions
- Bookmarks toolbar items placed on the toolbar from the Customize menu
Steps to reproduce
- Set the browser to minimum width and observe the show more bookmarks button.
Expected result
- Show more bookmarks button does not overlap other buttons.
Actual result
- Show more bookmarks button overlaps other buttons.
Regression range
- Last good revision: a4a8521b307275498ecda987249e72150c3c110d
First bad revision: 0645b630915e38a3a37d076aa7f431a72387699e
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4a8521b307275498ecda987249e72150c3c110d&tochange=0645b630915e38a3a37d076aa7f431a72387699e
Unfortunately, I don't know for sure if bug 1795286 is the regressor.
Additional notes
- Attached a screen recording.
|
||
Comment 1•9 months ago
|
||
:atrif, could you try to find a regression range using for example mozregression?
|
||
Updated•9 months ago
|
|
|
||
Comment 3•9 months ago
|
||
:emilio, since you are the author of the regressor, bug 1795286, could you take a look?
For more information, please visit BugBot documentation.
|
Assignee | |
Updated•9 months ago
|
|
|
Assignee | |
Comment 4•9 months ago
|
||
This is the less ugly fix I can think of.
|
||
Updated•9 months ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00b832b66943 Make sure that bookmark items always have size for the chevron at least. r=Gijs
|
||
Comment 6•9 months ago
|
||
| bugherder | ||
|
|
||
Comment 7•9 months ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox118towontfix.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 8•9 months ago
|
||
I think this can probably ride the train, this is an old regression.
|
Reporter | |
Comment 9•9 months ago
•
|
||
Verified fixed with 119.0a1 (2023-08-30) on Windows 10x64, macOS 12 and Ubuntu 22. The Show More bookmarks button no longer overlaps other buttons after following the steps from comment 0.
|
|
||
Updated•7 months ago
|
|
|
Reporter | |
Updated•7 months ago
|
Description
•