Closed Bug 1850086 Opened 9 months ago Closed 8 months ago

`pointerDown(ButtonType.MIDDLE)` and `pointerDown(ButtonType.RIGHT)` synthesizes wrong `buttons` value

Categories

(Remote Protocol :: Agent, defect, P3)

Product:
Remote Protocol
Component:
Agent
Type:
defect

Tracking

(firefox119 fixed)

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Whiteboard: [webdriver:m8][webdriver:external][webdriver:relnote])

Attachments

(1 file)

Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly
48 bytes, text/x-phabricator-request
Details | Review

If you call pointerDown(ButtonType.MIDDLE), you'll see a mousedown event whose buttons value is 2, similarly, pointerDown(ButtonType.RIGHT), you'll see a mousedown whose buttons is 4. However, the values should be swapped.

Thanks Masayuki! FYI geckodriver just forwards the WebDriver command to Marionette. So lets get it moved to the right component.

Component: geckodriver → Marionette
Product: Testing → Remote Protocol

MouseButton.buttons value for middle button is 4, and for right button is
2. However, their button values are 1 and 2. Therefore, their values
cannot be computed with Math.pow simply.

Attachment #9350411 - Attachment description: WIP: Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly → Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly
Attachment #9350411 - Attachment description: Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly → WIP: Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly
Attachment #9350411 - Attachment description: WIP: Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly → Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/a0cba0c9a320
Make `Actions` compute `buttons` value from `button` value correctly r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41796 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/a0cba0c9a320

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m8][webdriver:external][webdriver:relnote]
Component: Marionette → Agent
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: