Closed Bug 1849703 Opened 9 months ago Closed 9 months ago

The Fakespot Sidebar border is missing with High Contrast

Categories

(Firefox :: Shopping, defect, P3)

Product:
Firefox
Component:
Shopping
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
119 Branch
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox-esr102 --- disabled
firefox-esr115 --- disabled
firefox116 --- disabled
firefox117 --- disabled
firefox118 --- disabled
firefox119 --- verified

People

(Reporter: rdoghi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [fidefe-shopping])

Attachments

(2 files)

HighContrastMac.png
2.05 MB, image/png
Details
Bug 1849703 - Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=Gijs,Itiel
48 bytes, text/x-phabricator-request
Details | Review
Attached image HighContrastMac.png —

Found in

  • Nightly 118.0a1 (2023-08-22)

Affected versions

  • Nightly 118.0a1 (2023-08-22)

Affected platforms

  • Mac

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Enable High Contrast.

Steps to reproduce

  1. Reach https://www.amazon.com/dp/B09F56RRF8/ref=vp_d_cpf-substitute-widget_pd?_encoding=UTF8&pf_rd_p=f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pf_rd_r=H70ERT7R4QGKSD4DH14X&pd_rd_wg=QXmZV&pd_rd_i=B09F56RRF8&pd_rd_w=LWAch&content-id=amzn1.sym.f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pd_rd_r=28393c3e-7f14-46bb-878a-82ec1fbb043f

Expected result

  • The Fakespot shopping address bar should have a border when High Contrast is enabled.

Actual result

  • There is no difference in Color or delimitation between the page Content and the Fakespot sidebar on Mac when high contrast is enabled.

Regression range
Not Applicable

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Whiteboard: [fidefe-shopping]
Accessibility Severity: --- → s3
Priority: -- → P3

We triaged this a bit lower, but would you like to take it as well, :ayeddi?

Flags: needinfo?(ayeddi)
Blocks: 1848037
Flags: needinfo?(ayeddi)

(In reply to Rares Doghi, Desktop QA from comment #0)

Expected result

  • The Fakespot shopping address bar should have a border when High Contrast is enabled.
    The lack of the border of the Shopping sidebar itself affects all desktop platforms, thus attaching the patch for prefers-contrast for all platforms

Using --in-content-box-border-color since it resoves to the CanvasText and is using the same variable pair applied to the #shopping-container by default.

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
See Also: → 1851840
Attachment #9351729 - Attachment description: Bug 1849703 - Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=jhirsch,Jamie → Bug 1849703 - Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=Gijs,Itiel,shopping-reviewers,desktop-theme-reviewers
Attachment #9351729 - Attachment description: Bug 1849703 - Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=Gijs,Itiel,shopping-reviewers,desktop-theme-reviewers → Bug 1849703 - Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=Gijs,Itiel
Pushed by ayeddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d365cbdc2629
Adding a border to the Shopping sidebar to separate it from the page content on HCM. r=desktop-theme-reviewers,shopping-reviewers,Gijs,Itiel
Flags: qe-verify+

https://hg.mozilla.org/mozilla-central/rev/d365cbdc2629

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(ayeddi)
status-firefox118: affected → wontfix
Flags: needinfo?(ayeddi)

Verified fixed using Firefox Nightly 119.0a1 (20230907213402) on MacOS 11 and MacOS 12.

Status: RESOLVED → VERIFIED
status-firefox119: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: