Closed Bug 1840818 Opened 10 months ago Closed 10 months ago

Enable Custom Highlight API in Nightly

Categories

(Core :: DOM: Core & HTML, task)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: jjaschke, Assigned: jjaschke)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

The Custom Highlight API is not 100% feature-complete, but it is in a state good enough to enable it, as there is small risk of breaking existing webapps.

Setting the pref should be done after the code freeze for 116 is over, i.e. at July 4th.

Pushed by jjaschke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a76eed51a093
Enable Custom Highlight API in Nightly. r=dom-core,sefeng

Backed out for causing mochitest failures in test_interfaces.html

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface HighlightRegistry to all webpages as a property on 'window'? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

And xpcshell failures: https://treeherder.mozilla.org/logviewer?job_id=421473216&repo=autoland

Flags: needinfo?(jjaschke)
Attachment #9342220 - Attachment description: Bug 1840818: Enable Custom Highlight API in Nightly. r=#dom-core → Bug 1840818: Enable Custom Highlight API in Nightly. r=#dom-core,#webidl
Pushed by jjaschke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16be47412c5c
Enable Custom Highlight API in Nightly. r=dom-core,sefeng,webidl,devtools-reviewers,nchevobbe,edgar
Flags: needinfo?(jjaschke)

Backed out for causing multiple failures related to highlight.

Flags: needinfo?(jjaschke)
Pushed by jjaschke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0d642bf72e6
Enable Custom Highlight API in Nightly. r=dom-core,sefeng,webidl,devtools-reviewers,nchevobbe,edgar
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Regressions: 1841987
Flags: needinfo?(jjaschke)

Did you want to add this to the Nightly release notes? Feel free to nominate by setting the relnote-firefox flag to ? if yes!

Flags: needinfo?(jjaschke)

Release Note Request (optional, but appreciated)
[Why is this notable]: Custom highlight API allows web developers to give ranges an appearance.
[Affects Firefox for Android]: Yes
[Suggested wording]: Partial support for the custom highlight API is now available in Nightly.
[Links (documentation, blog post, etc)]: https://drafts.csswg.org/css-highlight-api-1/

relnote-firefox: --- → ?
Flags: needinfo?(jjaschke)

Thanks, added to the Fx117 Nightly release notes.

FF117 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/28291

Above this is described as "Partial support for the custom highlight API".

Essentially "can you outline what is partial about the implementation?" so I can work out how to record this in the compatibility table.

Flags: needinfo?(jjaschke)

Hi Hamish, sure!

  • Text-decoration and Text-Shadow do not work yet.
  • There are failing tests regarding inheritance (e.g. this test)
  • The topic of event handling hasn't been dealt with at all, but that is also not yet finalized in the spec.

For the moment, custom highlight API is only enabled on Nightly to give it some exposure and to enable fuzzing. Our plans are to implement the remaining features and ship custom highlight for all users in H2.

Flags: needinfo?(jjaschke)

Thanks very much Jan - just what I needed. Captured in the compatibility data.

Summary: Enable Custom Highlight API → Enable Custom Highlight API in Nightly

This has been dropped from the Nightly release notes now that we're more than 3 cycles out since it was added. Feel free to re-nominate once this is ready to ride the trains to release.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: