Implement "browsingContext.setViewport" command
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Tracking
(firefox117 fixed)
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 3 open bugs, )
Details
(Whiteboard: [webdriver:m8], [wptsync upstream] [webdriver:relnote])
Attachments
(2 files, 1 obsolete file)
The browsingContext.setViewport command will allow clients to adjust the size of the visible viewport.
As of now it is not available in the specification but should get merged soon.
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Comment 1•11 months ago
|
||
The PR got merged and we basically could get started with the implementation. But I would suggest we are waiting for at least the tests Alex is currently working on. The first PR can be found at https://github.com/web-platform-tests/wpt/pull/40584.
|
|
Assignee | |
Comment 2•11 months ago
|
||
I have started to implement this command yesterday and it was not that difficult given that most of the CDP code was already written. While testing I actually noticed a bug in CDP, which we should fix as a follow-up once the BiDi support has been landed.
|
|
Assignee | |
Comment 3•11 months ago
|
||
|
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Comment 4•11 months ago
|
||
I'm going to wait until the Webdriver tests are merged and synced to mozilla-central. There are a couple of enhancements that I would like to do for a better coverage.
|
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Comment 5•10 months ago
|
||
Already existing tests on the wpt repository which haven't downstreamed yet.
|
|
Assignee | |
Comment 6•10 months ago
|
||
Depends on D181905
|
|
Assignee | |
Comment 7•10 months ago
•
|
||
The patches are fully reviewed and only waiting for the next downstream sync.
Julian, could you please take care of the following while I'm away?
- Abandoning the first revision because it's not needed once Alex' tests are available
- Rebasing the patches including fixes for the merge conflicts mainly for the wpt manifest files
- Landing the patch
Thanks!
|
||
Updated•10 months ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcdece3e8f97 [webdriver-bidi] Implement "browsingContext.setViewport" command. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/238a99a8900a [wdspec] Enhanced tests for browsingContext.setViewport. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41014 for changes under testing/web-platform/tests
|
||
Comment 11•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bcdece3e8f97
https://hg.mozilla.org/mozilla-central/rev/238a99a8900a
Upstream PR merged by moz-wptsync-bot
|
||
Updated•9 months ago
|
Description
•