Unwaive Xrays during Node serialization
Categories
(Remote Protocol :: WebDriver BiDi, task, P2)
Tracking
(firefox116 fixed)
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: Sasha, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m7], [wptsync upstream][webdriver:relnote])
Attachments
(2 files)
At the moment, we unwaive Xrays only when we try to access shadow root of the node: https://searchfox.org/mozilla-central/source/remote/webdriver-bidi/RemoteValue.sys.mjs#476. But in case we try to serialize shadow root directly like in this wdspec test: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/script/evaluate/result_node.py#448 it's not happening, and it causes the check for shadow root wrongly identify this node as not shadow root and serialize children even when includeShadowTree is none. So we should do unwaiving earlier.
The test is fixed in Github repo: https://github.com/web-platform-tests/wpt/pull/40361. So we should probably wait until it's synced to m-c.
|
Assignee | |
Comment 1•11 months ago
|
||
I wonder if we could unwaive XRays immediately at the beginning of serializeNode() or if that would have some side-effects. If we can do that we won't need to do it anymore in getSharedIdForNode().
|
Reporter | |
Updated•11 months ago
|
|
|
Assignee | |
Comment 2•11 months ago
|
||
|
||
Updated•11 months ago
|
|
|
Assignee | |
Comment 3•11 months ago
|
||
Depends on D181906
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05b7fbb7bac3 [webdriver-bidi] Unwaive Xrays once during Node serialization. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/55b5600b5957 [wdspec] Improve ShadowRoot tests for children and mode properties. r=webdriver-reviewers,jdescottes
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
|
||
Comment 6•11 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05b7fbb7bac3
https://hg.mozilla.org/mozilla-central/rev/55b5600b5957
|
|
Assignee | |
Comment 7•11 months ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #5)
Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.
Hi James, can you please help and check what caused this failure in creating the upstream PR? Thanks!
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40809 for changes under testing/web-platform/tests
|
||
Updated•11 months ago
|
Upstream PR merged by whimboo
|
||
Updated•10 months ago
|
Description
•