Closed
Bug 1824957
Opened 1 year ago
Closed 1 year ago
Stop using XUL layout for nsTreeBodyFrame.
Categories
(Core :: XUL, task)
Core
XUL
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•1 year ago
|
||
Surprisingly straight-forward:
Use SimpleXULLeafFrame, and override GetIntrinsicBSize to implement the rows
attribute.
Use DidReflow to manage the reflow callback which is equivalent to what the old
code did.
|
|
Assignee | |
Comment 2•1 year ago
|
||
And some related tests.
A bunch of -moz-box* properties are web exposed, so I'll file a
follow-up for hiding them.
Depends on D173818
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30b054c6db5a Use SimpleXULLeafFrame for treebody. r=jwatt
|
|
Assignee | |
Comment 4•1 year ago
|
||
The selection getter is nullable. Not having this check causes
browser_experimental_features_filter.js to fail due to the thrown
exception.
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/103bb482b0bd Null-check tree selection in preferences search. r=Gijs
|
||
Comment 6•1 year ago
|
||
Backed out for causing reftest failures on treechildren-padding-percent-1.xhtml
Flags: needinfo?(emilio)
|
||
Updated•1 year ago
|
Attachment #9325410 -
Attachment description: Bug 1824957 - Use SimpleXULLeafFrame for treebody. r=jwatt,#layout → Bug 1824957 - Use SimpleXULLeafFrame for treebody. r=jwatt
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4afe60aa1ef4 Use SimpleXULLeafFrame for treebody. r=jwatt
|
|
Assignee | |
Updated•1 year ago
|
status-firefox111:
--- → fixed
status-firefox112:
--- → fixed
status-firefox113:
--- → fixed
status-firefox-esr102:
--- → fixed
status-thunderbird_esr102:
--- → fixed
status-thunderbird_esr91:
--- → fixed
Keywords: leave-open
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
|
||
Comment 9•1 year ago
|
||
| bugherder | ||
|
||
Updated•1 year ago
|
status-firefox111:
fixed → ---
status-firefox112:
fixed → ---
status-firefox113:
fixed → ---
status-firefox-esr102:
fixed → ---
status-thunderbird_esr102:
fixed → ---
status-thunderbird_esr91:
fixed → ---
|
||
Comment 10•1 year ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e21add6bf2c Remove a bunch of now completely dead XUL layout code. r=layout-reviewers,desktop-theme-reviewers,devtools-reviewers,dao,TYLin
|
|
Assignee | |
Updated•1 year ago
|
Keywords: leave-open
|
||
Comment 11•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•