Closed
Bug 1824667
Opened 1 year ago
Closed 1 year ago
Remove nsTextBoxFrame.
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
We only use it for middle-cropping. Luckily we don't have use cases for middle cropping that require any of the other features of nsTextBoxFrame, so we can just replace it with something simpler.
|
Assignee | |
Comment 1•1 year ago
|
||
Factor a MiddleCroppingBlockFrame that does the double reflow shenanigans.
That should both be faster and easier to reason about. The only thing we need
to be careful about is to use the current inline coord from the line layout if
present to compute the real available isize.
Depends on D173601
|
|
Assignee | |
Comment 2•1 year ago
|
||
Use a MiddleCroppingBlockFrame subclass that looks at the value attribute
instead. We don't need accesskey etc for these so we can just reuse it as is.
Depends on D173668
|
|
Assignee | |
Updated•1 year ago
|
Keywords: leave-open
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e14f043b6568 Factor middle-cropping out of nsFileControlFrame. r=jfkthame,layout-reviewers
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bac27e460973 Fix Bp-hybrid bustages on MiddleCroppingBlockFrame.cpp. r=emilio
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47e92b0d5aec Remove nsTextBoxFrame. r=jwatt
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•1 year ago
|
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
|
||
Updated•1 year ago
|
Keywords: leave-open
|
||
Updated•1 year ago
|
status-firefox113:
--- → ?
|
||
Updated•1 year ago
|
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•