Allow XUL to shrink by default
Categories
(Core :: XUL, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regressed 2 open bugs)
Details
Attachments
(2 files)
Bug 1821920 and bug 1821871 are instances of an interesting behavior change from bug 1820534.
The default flex-basis of old XUL was auto instead of max-content, so stuff that used to wrap now no longer does in an horizontal flex container:
This code prevents items from shrinking.
Per the comment, a few tests relied on this, but I believe it should generally be safe to shrink the items. This only causes to shrink if they have an explicit width but no explicit min-width.
Some tests like test_mousescroll.xhtml hit this, because they have explicit sizes but min-width: auto ends up being 0 effectively, but I believe we should tweak those tests instead.
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
Bug 1821920 and bug 1821871 are instances of an interesting behavior change
from bug 1820534.
The default flex-basis of old XUL was auto instead of max-content, because of this code:
So stuff that used to wrap now no longer does, in an horizontal flex container,
since xul.css prevents XUL elements from shrinking.
Per the comment, a few tests relied on this, but I believe it should generally
be safe to shrink the items. This only causes to shrink if they have an
explicit width but no min-width (including min-width: auto).
Some tests like test_mousescroll.xhtml hit this, because they have explicit
sizes but min-width: auto ends up being 0 effectively, but I believe we should
tweak those tests instead.
|
||
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3fb28ffc489 Allow XUL elements to shrink-by-default. r=dholbert
|
||
Comment 3•1 year ago
|
||
Backed out for causing reftest failures on 540247-1.xhtml
There are also these TVs if you could take a look.
|
|
Assignee | |
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aa9a63adab87 Allow XUL elements to shrink-by-default. r=dholbert
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
|
||
Comment 6•1 year ago
|
||
If the browser is small in width, the Findbar buttons and result description will wrap.
See screencast: https://youtu.be/qjR3ViLsU3w .
Not that there is anything wrong with it, is this intentional change?
|
|
Assignee | |
Comment 7•1 year ago
|
||
It's not intentional as "I was looking at the findbar when making this change", but it's not surprising and since it's a progression (before they overflowed) seems ok.
Description
•