Closed Bug 1820360 Opened 1 year ago Closed 1 year ago

Use new generated password after previous is saved in password manager

Categories

(Toolkit :: Password Manager, enhancement, P1)

Product:
Toolkit
Component:
Password Manager
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: serg, Assigned: serg)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxcm-password-generator])

Attachments

(1 file)

Bug 1820360 - Use new generated password after previous is saved in password manager r=#credential-management-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Today when we generate a password for some origin, it's placed in the in-memory cache and stays there until browser restart. The intent was to make sure users don't lose generated password while they navigate through registration pages.

The flaw here is that when user creates a new account on the site where they recently created another account, we will keep giving them the same generated password. Which leads to password reuse.

We also autosave generated password right at the time of filling into a login without username.

This bug resets generated password when autosaved login is updated with username. By that time, user already has generated password stored and there is no value in preserving cached generated password.

Severity: -- → N/A
QA Whiteboard: [fxcm-password-generator]
Priority: -- → P1
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
QA Whiteboard: [fxcm-password-generator]
Whiteboard: [fxcm-password-generator]
Attachment #9321209 - Attachment description: Bug 1820360 - Use new generated password after previous is saved in password manager drop generated password when it's saved r=#credential-management-reviewers → Bug 1820360 - Use new generated password after previous is saved in password manager r=#credential-management-reviewers
Pushed by sgalich@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6438ef985f55
Use new generated password after previous is saved in password manager r=dimi

https://hg.mozilla.org/mozilla-central/rev/6438ef985f55

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
See Also: → 1674668
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: