Closed Bug 1819021 Opened 2 years ago Closed 2 years ago

[Windows] Some visual glitches can be seen on the forward page arrow when the Underline access keys setting is on

Categories

(Core :: Graphics, defect)

Desktop
Windows
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- unaffected
firefox111 --- fixed
firefox112 --- affected

People

(Reporter: csasca, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Found in

  • Firefox 112.0a1

Affected versions

  • Firefox 111.0b6
  • Firefox 112.0a1

Tested platforms

  • Affected platforms: Windows 10
  • Unaffected platforms: macOS, Ubuntu

Preconditions

  • Have the setting "Underline access keys when available" on from the Keyboard section in Ease of access in Windows settings

Steps to reproduce

  1. Launch Firefox
  2. Access any random page
  3. Resize Firefox window or click on back page then forward or refresh the page

Expected result

  • No parts of the underline is shown on the forward page arrow

Actual result

  • Parts of the underline are shown when browsing or resizing Firefox window (might take a few tries to reproduce it)

Regression range

  • Will see for a regression.

Additional notes

  • The issue can be seen in the attachment.
  • It's not reproducible 100% but it's easy enough to make it appear (may appear on the refresh button as well, can be seen for a moment in the attachment as well)
QA Whiteboard: [qa-regression-triage]
Component: DOM: UI Events & Focus Handling → Graphics

Searched for regression and it pinpointed between 2023-01-19 and 2023-01-20. Further bisection gave the following informations:

Found commit message:
Bug 1753349 (9/9): chore: update ANGLE to our fork's firefox-111 branch r=jgilbert

Differential Revision: https://phabricator.services.mozilla.com/D162655

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=64d81842d98ded6df5d9a473453ed75f2f8e33e4&tochange=8129ee5398d5ce34183dd2ca51c3aa1d27e9c318

Setting 111 to fixed - regressor was backed out of beta via a patch on Bug 1817240

:ErichDonGubler, since you are the author of the regressor, bug 1753349, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(egubler)

I suspect this is a similar root cause and symptom as 1817240. :ahale, what do you think here?

Flags: needinfo?(egubler)
Flags: needinfo?(ahale)

Can you attach about:support for the affected system? This looks like the issue we saw on Intel Skylake, so I'd like to know if it's the same GPU or a different one. In theory Firefox Nightly should have the regression fix since it landed last night I believe.

Flags: needinfo?(ahale) → needinfo?(catalin.sasca)
Attached file aboutsupport.txt

Hey Ashley, sure thing, here's the about:support from 111.0.

Flags: needinfo?(catalin.sasca)

Catalin can you still reproduce this?

Flags: needinfo?(catalin.sasca)

:csasca: To add some context to :jrmuizel's question, it's possible that this is a dupe of 1817240, which has been fixed.

I was not able to reproduce the issue on any of the affected builds, Firefox 111.0b6 and Firefox 112.0a1, so I cannot confirm the fix.
Catalin will return from PTO on Monday and he will investigate this issue.

Hey guys, just tried on Firefox 112.0b9 and 113.0a1 (2023-04-02) and I can't reproduce it anymore on Windows 10. Seems that Bug 1817240 which Erich mentioned might have fixed this. Will close it as wfm in this case. Thanks!

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(catalin.sasca)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: