Closed Bug 1818819 Opened 1 year ago Closed 1 year ago

Set pref layout.css.forced-color-adjust.enabled to true by default

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
relnote-firefox --- 113+
firefox113 --- fixed

People

(Reporter: fchasen, Assigned: fchasen)

References

Details

(Keywords: dev-doc-needed, Whiteboard: [fidefe-quality-foundation])

Attachments

(1 file)

Set the pref for layout.css.forced-color-adjust.enabled to true by default to enable it to be used to prevent applying forced colors on certain elments.

Whiteboard: [fidefe-quality-foundation]
Depends on: 1818227
Pushed by fchasen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/251530e20422
Enable support for forced-color-adjust property by default r=emilio

Backed out for causing xpc failures in devtools/shared/tests/xpcshell/test_css-properties-db.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5aa2b55eb19b133d270affbe0279338a0ad2b547

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/shared/tests/xpcshell/test_css-properties-db.js | run_test/< - [run_test/< : 100] The static database and platform do not agree on the property "forced-color-adjust"

[Failure log bc -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Unused whitelist item: {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property ‘forced-color-adjust’](https://treeherder.mozilla.org/logviewer?job_id=410433442&repo=autoland&lineNumber=4521)

Flags: needinfo?(fchasen)
Type: task → enhancement
Pushed by fchasen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f0a3d3602d8
Enable support for forced-color-adjust property by default r=emilio

Updated again, I had to remove this property from the whitelist now that it is enabled.

Tests appear to all be passing now:

Flags: needinfo?(fchasen)

Is this something we should call out in the Fx113 relnotes?

Flags: needinfo?(fchasen)

I think a quick mention would make sense, the intent to ship was in https://groups.google.com/a/mozilla.org/g/dev-platform/c/HCTHp4XMCKk/m/SN5Iboy_AQAJ

Please set the relnote-firefox dropdown to ? and fill out the form then :-)

Release Note Request

[Why is this notable]:
The “forced-color-adjust” property allows opting an element out of automatic color adjustment in Forced Color Mode.

[Affects Firefox for Android]:
Better support for High Contrast Mode colors.

[Suggested wording]:
The default “auto” value allows the colors to be automatically adjusted.

The “none” value opts out of any color changes. In combination with the “forced-color: active” media feature will allow authors to specify the exact colors that are used in situations where the automatically picked contrasting colors are not ideal.

“preserve-parent-color” is not implemented, as Firefox does not currently apply forced colors to SVG.

relnote-firefox: --- → ?
Flags: needinfo?(fchasen)
Pushed by fchasen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/129ee0d341a2
Enable support for forced-color-adjust property by default r=emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Added to the Fx113 Nightly relnotes.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: