Closed Bug 1812329 Opened 1 year ago Closed 1 year ago

Remove nsMenubarFrame

Categories

(Core :: XUL, task)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.

This ended up being a lot more straight-forward than the menu changes.

TLDR:

  • nsMenuBarFrame -> XULMenuBarElement
  • nsMenuBarListener -> MenuBarListener

Rest should be rather straight-forward. I didn't want to export
MenuBarListener so moved some of its functions (the access key stuff)
over to LookAndFeel / KeyboardEvent.

This makes the following patch simpler.

Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0532ccefaa6f
Move accesskey out of nsMenubarListener. r=smaug

Otherwise we leak in some bc tests.

Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/d663fc115ab9
Improve cycle collection of the menubar listener. r=smaug

Backed out 2 changesets (5464978a27a8 and d663fc115ab9) for causing multiple leaks.

LATER EDIT: there are also multiple failures on browser_siteSpecificWorkArounds.js - Failure log

There are also multiple failures related to browser_blocking<something> which appeared later:
example 1;
example 2;
example 3;
example 4.

And failures on browser_partitionedLocalStorage.js - Failure log

Flags: needinfo?(emilio)
Attachment #9316432 - Attachment is obsolete: true
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/f3a15e75bc39
Add missing null-check for the case where we can't reach our window root from detach() anymore.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Regressions: 1817649
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: