Remove nsMenubarFrame
Categories
(Core :: XUL, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files, 1 obsolete file)
Assignee | ||
Comment 1•1 year ago
|
||
This ended up being a lot more straight-forward than the menu changes.
TLDR:
- nsMenuBarFrame -> XULMenuBarElement
- nsMenuBarListener -> MenuBarListener
Rest should be rather straight-forward. I didn't want to export
MenuBarListener so moved some of its functions (the access key stuff)
over to LookAndFeel / KeyboardEvent.
Assignee | ||
Comment 2•1 year ago
|
||
This makes the following patch simpler.
Assignee | ||
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0532ccefaa6f Move accesskey out of nsMenubarListener. r=smaug
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5464978a27a8 Remove nsMenuBarFrame. r=smaug
Assignee | ||
Comment 5•1 year ago
|
||
Otherwise we leak in some bc tests.
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d663fc115ab9 Improve cycle collection of the menubar listener. r=smaug
Comment 7•1 year ago
•
|
||
Backed out 2 changesets (5464978a27a8 and d663fc115ab9) for causing multiple leaks.
LATER EDIT: there are also multiple failures on browser_siteSpecificWorkArounds.js - Failure log
There are also multiple failures related to browser_blocking<something> which appeared later:
example 1;
example 2;
example 3;
example 4.
And failures on browser_partitionedLocalStorage.js - Failure log
Comment 8•1 year ago
|
||
Move accesskey out of nsMenubarListener. r=smaug
https://hg.mozilla.org/mozilla-central/rev/0532ccefaa6f
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c624797b9cf Remove nsMenuBarFrame. r=smaug
Comment 10•1 year ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/f3a15e75bc39 Add missing null-check for the case where we can't reach our window root from detach() anymore.
Comment 11•1 year ago
|
||
bugherder |
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Description
•