Add site-specific wrappers for subtitles on https://www.aol.com/video
Categories
(Toolkit :: Picture-in-Picture, enhancement)
Tracking
()
People
(Reporter: rdoghi, Assigned: bnasar)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fidefe-pip3])
Attachments
(1 file)
Found in
- Beta 110.0b5
Affected versions
- Nightly 111.0a1 (2023-01-24)
- Beta 110.0b5
- Release 109
- Esr 102.7
Affected platforms
- ALL
Steps to reproduce
- Reach https://www.aol.com/video
- Enable CC.
- Start PIP mode.
Expected result
- CC Subtitles should be displayed inside the Pip window.
Actual result
- The Subtitles are not displayed inside the Pip window.
Regression range
Also occurs in 92.0a1 (2021-08-02)
Hi! This is an enhancement rather than a defect as we only support subtitles for specific websites (most have custom implementations of subtitles) and websites that support WebVTT.
I just noticed that the video player for AOL is very similar to Yahoo Finance in Bug 1816656. There's already a patch in review for that bug that adds a video wrapper and registers it to Yahoo finance in picture_in_picture_overrides.js. We'd want to add the AOL URL to this file and video wrapper once it's available in mozilla-central.
Updated•1 year ago
|
Pushed by bnasar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/210bb4985c1b Added site-specific wrapper for subtitles on aol. r=kpatenio
Comment 6•1 year ago
|
||
bugherder |
Comment 7•1 year ago
|
||
Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.
Updated•1 year ago
|
Reporter | ||
Comment 8•1 year ago
|
||
Verified as fixed in our latest Nightly build 113.0a1 (2023-03-29) (64-bit).
Description
•