Implement RTCIceTransport.state
Categories
(Core :: WebRTC: Signaling, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(7 files, 2 obsolete files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
This is the bare minimum we need to get bug 1265827 working.
This will involve touching multiple places, including MediaTransportHandlerSTS, MediaTransportHandlerIPC, PMediaTransport, MediaTransportHandler, RTCRtpTransceiver, and RTCDtlsTransport. Most of this is a pretty straightforward copy/paste of what we're doing for DTLS state, so should not be too hard.
For this, we will need to add some ICE state-change signals to MediaTransportHandler that will live alongside the existing DTLS state-change signals here:
These will be connected to TransportLayerIce, similar to the way that the existing signals are connected to the TransportLayerDtls:
Once we have the new signals, we can then use them to update RTCIceTransport.state similar to how we update RTCDtlsTransport.state here:
and
|
Assignee | |
Comment 1•1 year ago
|
||
Actually, this has nothing to do with RTCPeerConnection.connectionState; that is based on RTCDtlsTransport.state, which we already have. Once we have this, we will want to use it to reimplement our existing implementation of RTCPeerConnection.iceConnectionState.
|
|
Assignee | |
Comment 2•6 months ago
|
||
|
||
Updated•6 months ago
|
|
|
Assignee | |
Comment 3•6 months ago
|
||
Depends on D193124
|
|
Assignee | |
Comment 4•6 months ago
|
||
Depends on D193125
|
|
Assignee | |
Comment 5•6 months ago
|
||
Depends on D193126
|
|
Assignee | |
Comment 6•6 months ago
|
||
Also, set up the cycle collection for the transport objects held by PCImpl
Depends on D193127
|
|
Assignee | |
Comment 7•6 months ago
|
||
Depends on D193128
|
|
Assignee | |
Comment 8•6 months ago
|
||
Depends on D193129
|
|
||
Comment 9•5 months ago
|
||
Comment on attachment 9362714 [details]
Bug 1811912: Fix bug where the old stream wasn't being closed after an ICE restart. r?mjf
Revision D193130 was moved to bug 1792042. Setting attachment 9362714 [details] to obsolete.
|
||
Comment 10•4 months ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 11•4 months ago
|
||
Depends on D193129
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 12•3 months ago
|
||
Depends on D193129
|
|
||
Updated•2 months ago
|
|
||
Comment 13•2 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65eb9f0691f0 Test cases for RTCIceTransport. r=jib https://hg.mozilla.org/integration/autoland/rev/0692ec0775c8 webidl for RTCIceTransport r=jib,webidl,saschanaz https://hg.mozilla.org/integration/autoland/rev/8c0e34780310 Basic webidl impl r=jib https://hg.mozilla.org/integration/autoland/rev/5eb89e1610b7 Handle ICE connection and gathering states on a per-transport basis. r=mjf https://hg.mozilla.org/integration/autoland/rev/e17aa225e500 Handling for state updates. r=jib https://hg.mozilla.org/integration/autoland/rev/da08fd49b4ec Remove redundant empty candidate signal. r=mjf https://hg.mozilla.org/integration/autoland/rev/502af1ea1f4c Update expectations in the ICE unit-test, and fix some handling of the "disconnected" state. r=mjf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44687 for changes under testing/web-platform/tests
|
||
Comment 15•2 months ago
|
||
Backed out for causing mochitest failures @ dom/tests/mochitest/general/test_interfaces.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/d569825df70b0d17ba27168cdee1552145d14bd2
Upstream PR was closed without merging
|
|
||
Comment 17•2 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f743d6b74f60 Test cases for RTCIceTransport. r=jib https://hg.mozilla.org/integration/autoland/rev/c0dd798d5c5d webidl for RTCIceTransport r=jib,webidl,saschanaz https://hg.mozilla.org/integration/autoland/rev/fd5b4b44fba4 Basic webidl impl r=jib https://hg.mozilla.org/integration/autoland/rev/a2abe7d0112f Handle ICE connection and gathering states on a per-transport basis. r=mjf https://hg.mozilla.org/integration/autoland/rev/e410081135ed Handling for state updates. r=jib https://hg.mozilla.org/integration/autoland/rev/476e830b9b9f Remove redundant empty candidate signal. r=mjf https://hg.mozilla.org/integration/autoland/rev/ef36a8aca9a2 Update expectations in the ICE unit-test, and fix some handling of the "disconnected" state. r=mjf
|
||
Comment 18•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f743d6b74f60
https://hg.mozilla.org/mozilla-central/rev/c0dd798d5c5d
https://hg.mozilla.org/mozilla-central/rev/fd5b4b44fba4
https://hg.mozilla.org/mozilla-central/rev/a2abe7d0112f
https://hg.mozilla.org/mozilla-central/rev/e410081135ed
https://hg.mozilla.org/mozilla-central/rev/476e830b9b9f
https://hg.mozilla.org/mozilla-central/rev/ef36a8aca9a2
Upstream PR merged by moz-wptsync-bot
|
||
Updated•2 months ago
|
|
||
Comment 20•1 month ago
|
||
FF125 MDN Docs work for this can be tracked in https://github.com/mdn/content/issues/32775. This primarily includes some tidying of the existing docs, compatibility updates, and an MDN release note.
FYI we didn't spot this initially because the keyword dev-docs-needed had not been added. Would appreciate that being added when something ships. We picked this up from BCD collector tests.
Description
•