Support "network.responseStarted" for cached responses
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Tracking
(firefox113 fixed)
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m6], [wptsync upstream] [webdriver:relnote])
Attachments
(2 files)
Handling cached responses for the network.responseStarted event depends on proposed changes for the fetch spec at https://whatpr.org/fetch/1540.html#concept-http-fetch
We have been rediscussing where the trigger should take place for cached response, and most likely this will happen before step 10 of https://whatpr.org/fetch/1540.html#http-network-or-cache-fetch if response is not null
For the initial implementation we will focus on the trigger for non-cached responses (in https://whatpr.org/fetch/1540.html#http-network-fetch)
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•1 year ago
|
||
This fixes two issues:
- the transferred size was missing from cached responseStarted events
- the fromCache flag needs to be read on the initial network event payload from devtools, because relying on the isFromCache logic used to build the addResponseStart payload does not properly detect all cached responses (eg for a cached 301)
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D171508
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02a176fbbb0b Support "network.response" events for cached responses r=webdriver-reviewers,whimboo,devtools-reviewers,ochameau https://hg.mozilla.org/integration/autoland/rev/58784e71c915 [wdspec] Add wdspec test for cached responseStarted events r=webdriver-reviewers,whimboo,jgraham https://hg.mozilla.org/integration/autoland/rev/07ab28076e34 1806802: apply code formatting via Lando
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39030 for changes under testing/web-platform/tests
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/02a176fbbb0b
https://hg.mozilla.org/mozilla-central/rev/58784e71c915
https://hg.mozilla.org/mozilla-central/rev/07ab28076e34
|
|
||
Comment 6•1 year ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #4)
Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/39030 for changes under
testing/web-platform/tests
Julian, can you please check the upstream CI checks? Something failed for Chrome and as such the PR cannot be merged.
|
|
Assignee | |
Comment 7•1 year ago
|
||
I restarted the jobs, but I see Azure Pipelines (infrastructure/ tests: macOS) failing on several PRs, maybe there is an infra issue?
Upstream PR merged by jgraham
|
|
Assignee | |
Updated•1 year ago
|
Description
•