Closed Bug 1805414 Opened 1 year ago Closed 1 year ago

Remove nsMenuFrame

Categories

(Firefox :: Menus, task, P1)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Regressed 2 open bugs)

Details

Attachments

(2 files)

Stop creating legacy layout boxes for menus/menulists/menuitems.

Depends on: 1805415

Move all the event handling stuff to the DOM.

Depends on: 1805694
Severity: -- → N/A
Type: defect → task
Priority: -- → P1
Attachment #9308011 - Attachment description: WIP: Bug 1805414 - Remove nsMenuFrame and nsMenuParent. → Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug!,jamie!
Blocks: 1806293
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f11c529b2407
Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47c002d36372
Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao

This test passes on automation, somehow, probably due to timing.
Locally the click rolls up the popup (so you'd need a second click to
show the other popup).

This happens both with and without the patch, and given I debugged and
it is trivial to fix, well, make sure to hide the previously open menu
before clicking on another...

Regressions: 1808627
Regressions: 1808628
Regressions: 1808630
Blocks: 1804063
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b8542b7c655
Fix test_focus_general.xhtml locally. r=morgan
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Flags: needinfo?(emilio)
No longer regressions: 1808630
No longer regressions: 1808628
Regressions: 1808624
See Also: → 1808715
Regressions: 1808800
Regressions: 1809019
Regressions: 1809161
See Also: → 1808836
Regressions: 1811466
Regressions: 1811031
Regressions: 1812321
Regressions: 1812387
Regressions: 1810500
Regressions: 1815309
Regressions: 1815370
Regressions: 1815673
Regressions: 1816074
Regressions: 1809084
Regressions: 1817518
Regressions: 1818241
Regressions: 1823063
No longer regressions: 1823063
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: