The description of the DevTools settings items have white text on light-gray background in dark-theme mode
Categories
(DevTools :: General, defect)
Tracking
(firefox-esr102 unaffected, firefox107 wontfix, firefox108 wontfix, firefox109 verified)
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox107 | --- | wontfix |
| firefox108 | --- | wontfix |
| firefox109 | --- | verified |
People
(Reporter: pmagyari, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Screenshot 2022-11-24 at 16.09.45.png
Found in
- Firefox DevEdition 108.0b5
Affected versions
- Firefox 107.0
- Firefox Beta 108.0b5
- Firefox Nightly 109.0a1
Affected platforms:
- MacOS 11
- MacOS 12
- MacOS M1
Unaffected platforms
- Ubuntu 20.04
- Windows 7/10
Steps to reproduce
- Open Firefox.
- Go to about:addons -> themes -> enable Dark theme.
- Press (Fn) F12 to open DevTools panel.
- Click on Console in the DevTools panel (or any of the ones that have a settings cogwheel).
- Click on the settings cogwheel in the upper right corner of the panel.
- Hover over any of the items from the list to get a description of them.
Expected result
- The description is visible and in dark-theme mode accordingly.
Actual result
- The description has white text on a light gray background and it is hard to read.
Regression range
|
||
Updated•2 years ago
|
|
|
||
Comment 1•2 years ago
|
||
:emilio, since you are the author of the regressor, bug 1796849, could you take a look?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 2•2 years ago
|
||
Bug 1796849 implemented proper non-native tooltips so that we can draw
them in mismatched themes in GTK. That uses the InfoBackground /
InfoText color pair, which is the right color pair.
However on macOS InfoBackground didn't have dark-mode support (while
InfoText did), causing contrast issues.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
We implemented a basic ThemeGeometry-based tooltip in
https://hg.mozilla.org/integration/autoland/rev/e8d65866112f, but now
that we have non-native theme support for these it seems ok to just use
it.
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c749710bb41 Return a contrasting color for Infobackground in dark mode. r=spohl https://hg.mozilla.org/integration/autoland/rev/b848ef87dae2 Use non-native tooltips in the cocoa non-native theme too. r=spohl
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c749710bb41
https://hg.mozilla.org/mozilla-central/rev/b848ef87dae2
|
Reporter | |
Comment 6•1 year ago
|
||
I have verified the fix on Nightly 109.0a1 (20221208094253) on MacOS 11 and MacOS 12.
|
|
Reporter | |
Updated•1 year ago
|
Description
•