Open Bug 1801831 Opened 2 years ago Updated 6 months ago

The Persist Search tip is inconsistently displayed on the address bar

Categories

(Firefox :: Address Bar, defect, P3)

Firefox 108
Desktop
All
defect

Tracking

()

Tracking Status
firefox108 --- affected
firefox109 --- unaffected

People

(Reporter: cbaica, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Found in

  • Fx108.0b4

Affected versions

  • Fx 108.0b4

Affected platforms

  • Windows 10
  • Ubuntu 22.04
  • macOS

Preconditions
New profile.

Steps to reproduce

  1. Launch Firefox.
  2. Go to about:config and set browser.urlbar.showSearchTerms.featureGate to true.
  3. Open a new tab (Search Tip is displayed - NOT persist search tip).
  4. Perform a search using the address bar.
    Expected result
  • Persist search tip is displayed as this is the first time search terms are persisted in the session.
    Actual result
  • Persist search tip is not displayed.
  1. Open a new tab and perform another search.

  2. With the tab where the search was made in the foreground, perform a restart.
    Expected result

  • Persist search tip is displayed .
    Actual result
  • Persist search tip is not intially displayed on the foreground tab, only when switching back to another tab where a search was made.

Regression range

  • I'm not sure if this is a regression, as nothing new was added to the build.

Additional notes

  • This issue started occurring Tuesday, on the same build where in the previous day everything worked accordingly (persist search tip was displayed on the search from step 4).
  • This issue only occurs on beta. Nightly works as expected on the same machine (only the persist search tip is displayed.

Hi Cristian,

Right now, we only show one search tip in a session. The feature was added before I joined, but I'm going to assume it was done to avoid blasting the user with search tips.

In the first video, when you open a new tab you see a search tip on the new tab page. Thus, you've used your search tip allotment for the session. I think clicking on the urlbar will then remove that newtab search tip from appearing again (hence why when you restart the browser, you don't see it on the new tab page).

In the second video, I think the reason why the search tip isn't showing is because a dialog box shows. I believe we do a check to ensure that you don't get both a Firefox dialog box and a search tip at the same time.

I'll double check these to make sure I'm valid on my assumptions.

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #0)
Attempted to reproduce on macOS, followed steps

  • Created a new profile

  • Launched Fx

  • Went to about:config and set browser.urlbar.showSearchTerms.featureGate to true

  • Opened a new tab and observed search tip was displayed

  • Performed a search using the address bar

  • Result - persist search tip was displayed

  • After restarting the browser, persist search tip was shown when on search tab, but disappears when tab is switched and cannot be seen after navigating back to search tab

  • Note - behaviour was the same on Beta, Dev and Nightly

  • Note - only saw one search tip per browser session, consistent with comment above

Has STR: --- → yes
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: