Closed Bug 1801602 Opened 2 years ago Closed 1 year ago

The context menu search terms are not displayed in the urlbar for certain engines

Categories

(Firefox :: Address Bar, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
109 Branch
Tracking Status
firefox108 --- wontfix
firefox109 --- verified
firefox110 --- verified

People

(Reporter: cbaica, Assigned: jteow)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Found in

  • Fx 108.0b4

Affected versions

  • Fx108.0b4
  • Fx109.0a1

Affected platforms

  • Windows 10
  • Ubuntu 22.04
  • macOS

Preconditions

  • browser.urlbar.showSearchTerms.featureGate set to true.
  • set default engine to Bing or Duckduckgo

Steps to reproduce

  1. Launch Firefox.
  2. Go to en.wikipedia.org.
  3. Select a word or a phrase.
  4. Right click it and from the context menu choose "Search <engine> for <prhase>".

Expected result

  • SERP is displayed and search term is displayed in the address bar.

Actual result

  • SERP is displayed with the FULL link for the search visible in the address bar.

Regression range

  • This is not a regression. Looks like context menu for Bing and DDG didn't work from the begining of persist term.

Additional notes

  • Persist search term for context menu while using Google as a default engine works correctly.
Assignee: nobody → jteow
Status: NEW → ASSIGNED
Has STR: --- → yes
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71eb757374eb
Enable showSearchTerms to check contextmenu purpose - r=adw,Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Flags: in-testsuite+

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jteow)

I think it's fine for this patch to ride the trains since we won't be targeting Fx-108 in the experiment.

Flags: needinfo?(jteow)

The issue is verified fixed in the latest Fx 110 nightly and Fx 110.RC. Context menu searches now correctly display persisted search terms for Bing and DDG.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: