Closed
Bug 1800851
Opened 2 years ago
Closed 2 years ago
When the search bar is enabled, the search term persist feature should be automatically disabled
Categories
(Firefox :: Settings UI, enhancement)
Tracking
()
VERIFIED
FIXED
109 Branch
People
(Reporter: vlucaci, Assigned: jteow)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
Screenshot 2022-11-16 at 11.44.26.png
Found in
- 108.0b2
Affected versions
- 108.0b2
- 109.0a1
Tested platforms
- Affected platforms: Windows 11, macOS 12, Ubuntu 22
Preconditions
- Enable the feature by setting browser.urlbar.showSearchTerms.featureGate to true.
Steps to reproduce
- Go to about:preferences#search.
- Select the "Add Search bar in toolbar"
Expected result
- "Add search bar in toolbar" is selected, and the "Use the address bar for search and navigation" becomes unselected , alongside with the Persist Feature checkbox.
Actual result
- "Add search bar in toolbar" is selected, and the "Use the address bar for search and navigation" becomes unselected , however the user can still interact with the Persist Feature checkbox.
|
Reporter | |
Updated•2 years ago
|
Component: Preferences → Settings UI
Product: Toolkit → Firefox
|
Assignee | |
Comment 1•2 years ago
|
||
While trying to simplify the test code prior to landing the initial preference
panel update, I removed some checks in the test that ensured the checkbox
was actually being checked if the user enabled the search bar while the search
panel was opened. Hence how the tests passed despite the fact that I neglected
to include a listener.
|
||
Updated•2 years ago
|
Assignee: nobody → jteow
Status: NEW → ASSIGNED
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bc5c000443b showSearchTerms checkbox should listen to search bar changes - r=adw,settings-reviewers
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
|
||
Comment 4•1 year ago
|
||
This is verified fixed in the latest Fx 110.0b5 and Fx 111.0a1 on Windows 10, Ubuntu 22 and macOS. The checkbox becomes read-only when the search bar is enabled in about:preferences#search.
You need to log in
before you can comment on or make changes to this bug.
Description
•