The Star icon (“Bookmark this page/Edit this bookmark”) can’t be reached using keyboard navigation
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | --- | verified |
People
(Reporter: asoncutean, Assigned: emilio)
References
(Regression)
Details
(Keywords: access, regression)
Attachments
(1 file)
Found in
- 108.0a1 (20221107094526)
Affected versions
- 108.0a1 (20221107094526)
Affected platforms
- Windows 10
- macOS 12
- Ubuntu 20.04
Steps to reproduce
- Open any website
- Using keyboard navigation (Tab, right/left arrow) try to reach the Star icon button inside the search bar
Expected result
- The star button can be reached and focused.
Actual result
- The star button is skipped.
Regression range
- First bad: aa325161aae5e555cab4d44b6662bbe029d26a5d
- Last good: 4ff88d45f59c4357dcc71ddf4ad5344a38f9944d
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff88d45f59c4357dcc71ddf4ad5344a38f9944d&tochange=aa325161aae5e555cab4d44b6662bbe029d26a5d
- Potentially regressed by: 1790616
Additional notes
- Screen reader navigation is also affected by this behavior
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1790616
:emilio, since you are the author of the regressor, bug 1790616, could you take a look?
For more information, please visit auto_nag documentation.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
The existing check didn't work for visibility: collapse items.
Before switching to modern flexbox, we were saved by the width==0 check, but
modern flexbox preserves the padding of collapsed items (even though they take
no space and aren't painted).
checkVisibility() is the right thing to check for this, and should also handle
visibility: hidden properly as a bonus.
|
|
||
Comment 3•2 years ago
|
||
The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:emilio, could you consider increasing the severity?
For more information, please visit auto_nag documentation.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5971a8c289f3 Use a more reliable visibility check in toolbar key navigation. r=Gijs
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
|
||
Comment 7•2 years ago
|
||
Verified - Fixed in latest Nightly 108.0a1 (build id: 20221110044858) using Windows 10, macOS 12 and Ubuntu 20. “Bookmark this page/Edit this bookmark” star icon can be reached using the keyboard navigation.
|
||
Updated•11 months ago
|
Description
•