The overflow arrow is moved to the right side after signing into a sync account that has bookmarks inside the Bookmark Toolbar
Categories
(Firefox :: Theme, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | --- | verified |
People
(Reporter: atrif, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
image.png
Found in
- 108.0a1 (20221106212619)
Affected versions
- Firefox 108.0a1 (20221106212619)
Tested platforms
- Affected platforms: Windows 10x64, macOS 12, Windows 10x64
- Unaffected platforms: none
Steps to reproduce
- Sign in with a sync account with multiple bookmarks on the Bookmarks Toolbar.
- Enter fullscreen and enter Customize toolbar menu.
- Observe the Overflow menu arrow.
Expected result
- Overflow menu arrow does not move out of place.
Actual result
- Overflow menu arrow is moved.
Regression range
- Last good revision: 4ff88d45f59c4357dcc71ddf4ad5344a38f9944d
First bad revision: aa325161aae5e555cab4d44b6662bbe029d26a5d
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff88d45f59c4357dcc71ddf4ad5344a38f9944d&tochange=aa325161aae5e555cab4d44b6662bbe029d26a5d
Additional notes
- Attached a screenshot.
- The issue does reproduce without entering the fullscreen and Customize menu as well but int's more intermittent.
|
Reporter | |
Comment 1•2 years ago
|
||
|
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
:emilio, since you are the author of the regressor, bug 1790616, could you take a look?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 3•2 years ago
|
||
I don't see this locally on Linux on the latest nightly, following the STR in comment 0, am I missing something?
|
|
Reporter | |
Comment 4•2 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)
I don't see this locally on Linux on the latest nightly, following the STR in comment 0, am I missing something?
Hmm, I can reproduce this constantly on Windows 10 with my sync test profile after entering fullscreen and Customize mode. I will attach one of the affected profiles, maybe this will help. Thank you!
|
|
Assignee | |
Comment 6•2 years ago
|
||
Thanks, with that profile I can reproduce.
|
|
Assignee | |
Comment 7•2 years ago
|
||
If the user has a lot of bookmarks, there's a point in time where we're
computing the overflow menu arrow position, but we still haven't removed
the bookmark items from the toolbar.
This causes a wrong offset to be computed, because -moz-fit-content
computes a very large width to fit all the bookmarks.
In general, -moz-fit-content can cause stuff to overflow the browser
window (this didn't happen before modern flexbox because XUL didn't
respect min-width so aggressively). This comes from bug 1610497 and I
believe we could get rid of it.
At least I don't think it has an effect on actual window width anymore,
because the ConvertsToLength() check doesn't pass here:
This is true at least since we switched to <html> root for
browser.xhtml.
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/823c09b9eaa6 Remove min-width override while customizing. r=Gijs,dao
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 11•2 years ago
|
||
Verified fixed with Firefox 108.0a1 (20221107212933) on Windows 10x64, macOS 12 and Ubuntu 20.04. The Overflow arrow inside Customize menu is no longer moved after following STR from comment 0.
Description
•