Closed Bug 1799343 Opened 1 year ago Closed 1 year ago

Simplify XUL popup handling.

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Regressed 1 open bug)

Details

Attachments

(1 file)

  • Make non-menulist popups just absolute positioned top-layer items.
  • Simplify menulist popups to just be static-positioned items under nsMenuFrame.
  • Make non-menulist popups just absolute positioned top-layer items.
  • Simplify menulist popups to just be static-positioned items under
    nsMenuFrame.

We need to keep kPopupList only for nsMenuFrame. In the future it can be
removed, see TODO in xul.css

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a609c8c27ca8
Simplify XUL popup handling. r=TYLin
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/34f040f379b1
Remove another test whose expectation no longer holds.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/7f6358a0b692
Remove another test whose expectation doesn't hold.
Blocks: 1799580
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/3150074bccfd
Fix a crashtest that try didn't catch.
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/493c9ca00c91
Simplify XUL popup handling. r=TYLin

Backed out for causing mochitest failures on win7

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42d1b8742662
Simplify XUL popup handling. r=TYLin
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/63c270ba91ad
Remove a last-minute optimization that should work but breaks some automated tests.

Backed out for causing failures on browser_history_after_appMenu.js along with Bug 1799580

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c7654bfb11d
Simplify XUL popup handling. r=TYLin
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1811251
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: