Custom colors are not applied
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox106 | --- | affected |
firefox107 | --- | affected |
firefox108 | --- | affected |
People
(Reporter: phorea, Unassigned)
Details
(Whiteboard: [pdfjs-ux])
Attachments
(1 file)
2.65 MB,
image/gif
|
Details |
Note
- This issue only affects the
Custom Colors
panel when first interacting with it, theBasic colors
one works fine
Found in
- Firefox 107 beta 8
Affected versions
- Firefox 106.0.3
- Firefox 107 beta 8
- latest Nightly 108.a01 2022-11-02
Tested platforms
- Affected platforms: Windows 10x64
- Unaffected platforms: macOS 11, Ubuntu 22.04
Steps to reproduce
- Open a random PDF and select the
Draw
or theText
tools from the PDF toolbar. - Click on the Color button from the panel (black by default)
- Color window opens with Basic, Custom and Mix color areas (Define custom colors)
- Drag the mouse in the Mix color area (from the right) in order to modify the default color
- Select
Add to Custom Colors
button - Select the "OK" button and start drawing with the selected color
Expected result
4. Color|Solid
is modified accordingly
5. Selected color is added to the Custom Colors
section
6. Drawing is made with the previously defined color
Actual result
Color|Solid
stays Black and color is not changed.- Custom color is applied after interacting with a basic color.
Regression range
- Not a regression, reproduces since this feature entered Firefox.
Reporter | ||
Updated•2 years ago
|
Comment 1•2 years ago
|
||
PDF.js is just using the default HTML color picker which is platform-dependent, so it isn't really a pdf.js bug.
But for sure we can try to propose a better UI/UX to choose a color.
Comment 2•1 year ago
|
||
Can you also reproduce this bug with the buttons from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color?
Reporter | ||
Comment 3•1 year ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #2)
Can you also reproduce this bug with the buttons from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color?
The buttons from this MDN page are not reproducing the issue described in comment#0, using latest Nightly 115.0a1, Win 10 64-bit.
Comment 4•1 year ago
|
||
On the MDN page a color with a non-null luminance is preselected when in pdf.js, by default the color is black hence the default luminance is 0.
So the problem is with the Windows color picker.
Updated•1 year ago
|
Description
•