Closed Bug 1798097 Opened 2 years ago Closed 2 years ago

Blocklist builtin Windows MIDI device

Categories

(Core :: DOM: Device Interfaces, defect)

defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: bholley, Assigned: gsvelto)

References

Details

Attachments

(1 file)

I recently discovered that Windows automatically provisions a software MIDI device called Microsoft GS Wavetable Synth. Chrome disables this device for WebMIDI, and so we should too for compatibility reasons.

Interestingly, the device was disabled in Chromium because it was found to be insufficiently hardened against adversarial input. This has been our hypothesis about many MIDI devices since the beginning, and validates our position that exposing MIDI devices to sites without user consent is quite dangerous.

The bug notes that Chrome's security calculus hinged more on a belief that MIDI devices are rare than that exposing them is actually safe. This is presumably why the issue was addressed by simply blocklisting this specific device rather than anything systematic.

Gabriele, can you whip up a quick patch to implement a similar blocklist for compat reasons?

Flags: needinfo?(gsvelto)

Cooking up a patch

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5141f72f104a
Hide the Microsoft MIDI soft synthesizer from the list of outputs surfaced by WebMIDI r=bholley
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: