Closed Bug 1797965 Opened 2 years ago Closed 1 year ago

Google search engine ( which was removed via the SearchEngines policy) is automatically re-added after browser restart if restoring the default search engines

Categories

(Firefox :: Enterprise Policies, defect, P5)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- wontfix
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- wontfix
firefox111 --- fixed
firefox112 --- verified

People

(Reporter: emilghitta, Assigned: mkaply)

Details

Attachments

(1 file)

Bug 1797965 - Don't restore Google engine if hidden. r?standard8
48 bytes, text/x-phabricator-request
Details | Review

Notes

  • This is an ESR-only policy (reproducible only in ESR and Nightly builds).

Found in

  • 108.0a1

Affected versions

  • Firefox 108.0a1
  • Firefox 102.4.0esr

Tested platforms

  • Affected platforms: Windows 10 64bit, macOS 11 & Ubuntu 22.04

Preconditions
Add the following code inside the policies.json file:

{
"policies": {
"SearchEngines": {
"Remove": ["Google"]
}
}
}

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:preferences#search page.
  3. Click the "Restore Default Search Engines" button.
  4. Restart Firefox.

Expected result

  • "Google" search engine is no displayed.

Actual result

  • "Google" search engine is displayed

Regression range

  • I don't thinks that this is a regression.
Has STR: --- → yes
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Priority: -- → P5
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/a504a8c33625
Don't restore Google engine if hidden. r=Standard8

Backed out for causing xpc failures in browser/components/enterprisepolicies/tests/xpcshell/test_policy_search_engine.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0cebfb9103a56430744c2b7c3dade664b9092a80

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_policy_search_engine.js | xpcshell return code: 0
Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/d7eb7b1e5ce6
Don't restore Google engine if hidden. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/d7eb7b1e5ce6

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: qe-verify+

Reproducible on a 2023-01-25 Nightly build on Ubuntu 22.
Verified as fixed on Nightly 112.0a1(build ID: 20230302045723) on Ubuntu 22, macOS 12, Windows 11.
Google is no longer displayed in the Search Engines list after a browser restart.

Status: RESOLVED → VERIFIED
status-firefox112: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: