fixed positioned elements are broken on several websites
Categories
(Core :: Layout, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | + | verified |
| firefox109 | --- | verified |
People
(Reporter: soeren.hentzschel, Assigned: TYLin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
broken example 1
[Tracking Requested - why for this release]:
Fixed positioned elements are broken on several websites. To give you two examples:
Example 1:
- Open https://www.grossarlerhof.at/de/wohnen/angebote/auszeit-vom-alltag-4-3-so-do-~p95
- Press the large button to accept cookies
- Scroll down and up
Expected:
A bar with icons and buttons is fixed to the bottom of the window.
Actual:
The bar is not fixed to the bottom. Instead it's shown on the wrong position. (Sometimes it works, so maybe you have to reload a few times to reproduce the issue).
Example 2:
- Open https://forum.netcup.de/ (it uses a popular forum software so potentially many websites are affected)
- Scroll a bit down
- Press the top link "Anmelden oder registrieren"
Expected:
Fully visible dialog and the background mask is above the whole window.
Actual:
The dialog is truncated at top and the background mask does not cover the whole window.
|
Reporter | |
Comment 1•2 years ago
|
||
|
|
Reporter | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Comment 3•2 years ago
|
||
I believe https://searchfox.org/mozilla-central/rev/2d1097c27f31cb15f7588b043d691cda9710d14b/layout/base/nsCSSFrameConstructor.cpp#1318 was incorrectly moved inside of the if condition.
Tree Style Tab's pinned tab do not display correctly for 2nd+ pinned tabs.
STR:
- Install Tree Style Tab.
- Pinned 2 or more tabs.
- Press
F1to close and reopen Tree Style Tab tab bar.
This is regressed by bug 1797011 so maybe it is the same issue as comment 0.
|
|
||
Comment 5•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4dfea46f3cd0 Fix frame constructor save state restoration. r=TYLin,layout-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36698 for changes under testing/web-platform/tests
|
||
Comment 10•2 years ago
|
||
Backed out changeset 4dfea46f3cd0 (Bug 1797703) for causing reftest failures
Log: https://treeherder.mozilla.org/logviewer?job_id=394608395&repo=autoland&lineNumber=9099
Backout: https://hg.mozilla.org/integration/autoland/rev/308d2e5dbf05896e839f48ad806de50c75e4b7b3
Upstream PR was closed without merging
|
Assignee | |
Comment 12•2 years ago
|
||
Restore the old logic [1] prior to introducing Bug 1797011 Part 2.
[1] https://searchfox.org/mozilla-central/rev/85cbcecd24554c1fa88360412452ad0f7ed48630/layout/base/nsCSSFrameConstructor.cpp#1309-1335
[2] https://hg.mozilla.org/mozilla-central/rev/3f443cbb5bdd
The wpt test is written by Emilio Cobos Álvarez <emilio@crisal.io> in
https://phabricator.services.mozilla.com/D160523.
|
|
||
Updated•2 years ago
|
|
||
Comment 13•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ce77511413a Fix frame constructor save state restoration. r=emilio
|
|
||
Updated•2 years ago
|
|
||
Comment 14•2 years ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 18•2 years ago
|
||
Reproducible on a 2022-10-27 Nightly build on macOS 12 using the STR from Comment 0 and Comment 4. Confirming that all 3 issues are fixed on Firefox 108.0b2(build ID: 20221115200658) and Nightly 109.0a1(build ID: 20221116182402) on macOS 12, Windows 10, Ubuntu 22.
Description
•