Closed Bug 1797280 Opened 2 years ago Closed 2 years ago

[Win 7] - Browser window controls are displayed twice in full screen with menu bar and theme enabled

Categories

(Firefox :: Theme, defect)

Desktop
Windows 7
defect

Tracking

()

VERIFIED FIXED
109 Branch
Tracking Status
firefox-esr102 --- verified
firefox107 --- wontfix
firefox108 --- verified
firefox109 --- verified

People

(Reporter: Gabi, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image 2022-10-25_13h10_55.png

Found in

  • Firefox 107.0b4

Affected versions

  • Firefox 107.0b4
  • Firefox 108.0a1

Tested platforms

  • Affected platforms: Windows 7
  • Unaffected platforms: Ubuntu 18.4, macOS 10.12.6

Steps to reproduce

  1. Launch Firefox with menu bar enabled
  2. Enable any theme from about:addons
  3. Enter full screen (F11)

Expected result

  • Browser window controls are displayed twice in full screen when a theme is enabled

Actual result

  • Browser window controls should be displayed only once with theme and menu bar enabled

Regression range

  • Unlikely a recent regression, issue is reproducible with Fx 102
  • Will search for a regression asap.

Additional notes

  • Browser window controls are shown properly with menu bar and system theme enabled
  • See the attached screenshot
Has STR: --- → yes
QA Whiteboard: [qa-regression-triage]

I have investigated the issue in order to find a regression range, and it seems that Bug 1745189 is the regressor for this behavior:

Regressed by: 1745189

:emilio, since you are the author of the regressor, bug 1745189, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cd8b7e2b9b4
Fix windows 7 selectors to avoid overriding fullscreentoolbar rules. r=dao

Set release status flags based on info from the regressing bug 1745189

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9303508 [details]
Bug 1797280 - Fix windows 7 selectors to avoid overriding fullscreentoolbar rules. r=dao,Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very simple CSS fix.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9303508 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Attachment #9303508 - Flags: approval-mozilla-esr102?
QA Whiteboard: [qa-regression-triage] → [qa-regression-triage][qa-triaged]

Verified as fixed on Windows 7 x64 on Firefox 109.0a1 (2022-11-17).

Comment on attachment 9303508 [details]
Bug 1797280 - Fix windows 7 selectors to avoid overriding fullscreentoolbar rules. r=dao,Gijs

Approved for 108.0b3

Attachment #9303508 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on Windows 7 x64 on Firefox 108.0b3.

Comment on attachment 9303508 [details]
Bug 1797280 - Fix windows 7 selectors to avoid overriding fullscreentoolbar rules. r=dao,Gijs

Approved for 102.6esr.

Attachment #9303508 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+

Verified as fixed on Windows 7 x64 on Firefox 102.6esr.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-regression-triage][qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: