Closed Bug 1796073 Opened 2 years ago Closed 1 year ago

columnNumber in exceptions and stackTraces should be 0-based

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

defect
Points:
1

Tracking

(firefox109 fixed)

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: jdescottes, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m5], [webdriver:relnote] )

Attachments

(1 file)

Per https://w3c.github.io/webdriver-bidi/#stackframe-column-number

column number

The zero-based column number of the executed code, relative to the start of the line in the resource containing script.

AFAICT we are getting 1-based column and line numbers for our stack traces. We are correctly substracting 1 from our line numbers, but we don't apply the same for column numbers:

Interesting. This is most likely an oversight and we should get this fixed. Wasn't there a proposed test change by Maksim regarding the column number? I'm currently not able to find it.

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Blocks: webdriver:m5
Severity: -- → S3
Points: --- → 1
Flags: needinfo?(hskupin)
Priority: -- → P1
Whiteboard: [webdriver:m5]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b03d3afc321
[remote] Make columnNumber in exceptions and stackTraces 0-based. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Whiteboard: [webdriver:m5] → [webdriver:m5], [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: