Closed Bug 1794776 Opened 2 years ago Closed 1 year ago

[macOS] Firefox is not recognized as a recommended app to launch PDF files

Categories

(Firefox :: Shell Integration, defect)

Desktop
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1683278
Tracking Status
firefox106 --- affected
firefox107 --- affected

People

(Reporter: csasca, Unassigned)

References

Details

Found in

  • Firefox 106.0

Affected versions

  • Firefox 106.0
  • Firefox 107.0a1

Tested platforms

  • Affected platforms: macOS 13
  • Unaffected platforms: Windows 11, Ubuntu 22.04

Steps to reproduce

  1. Install firefox as .pkg
  2. Right click any PDF file and select Open With -> Other
  3. Search for Firefox in the list

Expected result

  • Firefox is seen as a Recommended PDF app like Safari or Chrome

Actual result

  • Firefox can't be selected

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the following attachment
  • By selecting "All applications" from the Enable settingand choosing Firefox the following message will be shown "It's not known if this applicatioon can open the PDF file".
Has STR: --- → yes
QA Whiteboard: [qa-regression-triage]

Doesn't seem to be a regression, the same behavior with Firefox 68.0.1 (first one to have .pkg installer).

See Also: → 1683278

Amir, can you please help prioritize this issue with the team? This seems to be a miss on mac where we are not even an optional pdf handler on the system.

Flags: needinfo?(ahabibi)

Technically, this should be straightforward: bump https://searchfox.org/mozilla-central/source/browser/app/macbuild/Contents/Info.plist.in and ensure that we have the appropriate PDF icon in the icons set. (bhearsum just captured instructions about bumping those icons, IIRC.)

(In reply to Nick Alexander :nalexander [he/him] from comment #3)

Technically, this should be straightforward: bump https://searchfox.org/mozilla-central/source/browser/app/macbuild/Contents/Info.plist.in and ensure that we have the appropriate PDF icon in the icons set. (bhearsum just captured instructions about bumping those icons, IIRC.)

Yep, I wrote up instructions for updating the Firefox icon and this appears as if it should be the same -- just a different file. We'll need a new icon for each branding (official, aurora, nightly, unofficial).

And although I'm sure we'd prefer to have a PDF icon, I'll note for completion that we could just re-use the existing document.icns (which isn't file type specific) if, eg: we're having trouble getting UX resources.

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)

(In reply to Nick Alexander :nalexander [he/him] from comment #3)

Technically, this should be straightforward: bump https://searchfox.org/mozilla-central/source/browser/app/macbuild/Contents/Info.plist.in and ensure that we have the appropriate PDF icon in the icons set. (bhearsum just captured instructions about bumping those icons, IIRC.)

Yep, I wrote up instructions for updating the Firefox icon and this appears as if it should be the same -- just a different file. We'll need a new icon for each branding (official, aurora, nightly, unofficial).

And although I'm sure we'd prefer to have a PDF icon, I'll note for completion that we could just re-use the existing document.icns (which isn't file type specific) if, eg: we're having trouble getting UX resources.

Where would that icon appear? My experience is that on Finder a preview of the file gets displayed, not an extension specific icon?
If the is about the icon appearing in the "Open With..." menu then can we not re-use the icon offered for html files currently?

We elected to not change the icon for PDFs. I'm going to mark this as a duplicate of Bug 1683278.

Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1683278
Flags: needinfo?(ahabibi)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.