Closed Bug 1794761 Opened 2 years ago Closed 2 years ago

Missing padding for the elements inside autoplay notification panel

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- wontfix
firefox105 --- wontfix
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- verified

People

(Reporter: bmaris, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot showing the issue
13.21 KB, image/png
Details
Bug 1794761 - Fix inline-end padding for menu items inside menulists on Windows r?gijs
48 bytes, text/x-phabricator-request
Details | Review

Found in

  • Latest Nightly 107.0a1

Affected versions

  • Nightly 107.0a1
  • Firefox 106.0 RC
  • Firefox 105.0.3 RC

Tested platforms

  • Affected platforms: Windows 10, Windows 11
  • Unaffected platforms: macOS 11.6 and Ubuntu 18.04

Steps to reproduce

  1. Visit https://strifer.link/html-video-autoplay-test/
  2. Click the autoplay permission notification from the URL bar
  3. Click the dropdown inside the permission notification

Expected result

  • The items inside the dropdown are displayed correctly and in a visually pleasant way.

Actual result

  • The items inside the dropdown have almost no padding on the right side compared to the left side.

Regression range

Additional notes

  • On macOS and Ubuntu this is not an issue, only on Windows.
  • Some other notification with the same dropdown could be affected, not sure which other notifications have a similar dropdown as autoplay though, I tried some other ones that I know like mic, webcam, geolocation etc but they don't have the same structure.
Flags: needinfo?(itiel_yn8)

Set release status flags based on info from the regressing bug 1729854

status-firefox-esr102: --- → affected
Has STR: --- → yes
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/07be7fb85564
Fix inline-end padding for menu items inside menulists on Windows r=mhowell

https://hg.mozilla.org/mozilla-central/rev/07be7fb85564

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

I verified that the padding is back inside the dropdown so I will go ahead and close it as verified for Firefox 108.
I did find a new issue related to the dropdown arrow being misplaced bug I logged a different bug 1796065 since it looks that the regressor for that issue is not this bug.

status-firefox108: fixed → verified

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(itiel_yn8)
status-firefox107: affected → wontfix
Flags: needinfo?(itiel_yn8)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: