Improve splitters for browser chrome use cases.
Categories
(Firefox :: Theme, task)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
(Regressed 1 open bug)
Details
Attachments
(5 files)
The browser chrome splitters are really trivial, they mostly just want to resize one of the elements, but splitters right now resize across the whole box container (minus non-flexible items depending on resizebefore/resizeafter).
I think we can simplify various bits quite a lot if we do some tweaks to splitters.
|
Assignee | |
Comment 1•2 years ago
|
||
This trivially enhances splitters so that resizing a single element,
which is a common thing to do in our front-end code, is easier.
|
|
Assignee | |
Comment 2•2 years ago
|
||
This is really what we want. Remove the CSS hack so we always flex.
Depends on D159069
|
|
Assignee | |
Comment 3•2 years ago
|
||
This simplifies the widget tracker code to avoid having to remove random
width attributes in all children.
Depends on D159070
|
|
Assignee | |
Comment 4•2 years ago
|
||
This is not easy to test precisely. What the width attribute / property
set is the preferred size, but the boxes can flex expanding that, which
may cause jumps when dragging. This is easy to see with the previous
patches on the urlbar / searchbar split.
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f75b1de2fb54 Implement resize{before,after}=none/sibling for XUL splitters. r=TYLin
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d08cef967d68 Improve behavior of splitters when child box is flexible. r=TYLin
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86161113004d Use resizebefore="sibling" for resizing the sidebar. r=Gijs
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d0d3534da317 Disable the new test for now to avoid orange on Linux.
|
|
Assignee | |
Comment 9•2 years ago
|
||
Need to make the test work with smaller viewports.
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f75b1de2fb54
https://hg.mozilla.org/mozilla-central/rev/d08cef967d68
https://hg.mozilla.org/mozilla-central/rev/86161113004d
https://hg.mozilla.org/mozilla-central/rev/d0d3534da317
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 11•2 years ago
|
||
Make sure that the relevant box is in the viewport even on automation.
|
||
Updated•2 years ago
|
|
||
Comment 12•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16f084b9ecdb Fix and re-enable test_splitter_sibling.xhtml.
|
|
||
Comment 13•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fde57ffc3be6 Use resize*=sibling for searchbar container. r=dao
|
||
Comment 14•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/16f084b9ecdb
https://hg.mozilla.org/mozilla-central/rev/fde57ffc3be6
|
|
Assignee | |
Comment 15•2 years ago
|
||
Sheriffs, can we back out https://hg.mozilla.org/mozilla-central/rev/fde57ffc3be6 from beta for causing bug 1795199? I'd rather do that than uplifting the relevant fixes.
|
|
||
Comment 16•2 years ago
•
|
||
Backed out changeset fde57ffc3be6 from beta for causing Bug 1795199 and as per Emilio's request.
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Description
•