Drop-down text is not properly aligned inside PDF forms
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox105 | --- | unaffected |
firefox106 | --- | unaffected |
firefox107 | --- | wontfix |
firefox108 | --- | verified |
People
(Reporter: atrif, Assigned: calixte)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Found in
- 107.0a1 (20221010033207)
Affected versions
- 107.0a1 (20221010033207)
Tested platforms
- Affected platforms: Windows 10x64, Ubuntu 20.04
- Unaffected platform: macOS 11.6
Steps to reproduce
- Open http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf.
- Click on The Country dropdown and choose a value.
Expected result
- The text is properly displayed for each value.
Actual result
- Some values are slightly cut off.
Regression range
- Last good revision: 23c9a4c9b468b43106f50295a52422851d71dfda
First bad revision: d9035fae6d3c0fd5bb6253561210fa05237c68e0
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=23c9a4c9b468b43106f50295a52422851d71dfda&tochange=d9035fae6d3c0fd5bb6253561210fa05237c68e0
Potential regressor: bug 1792052.
Additional notes
- Attached a screenshot with the issue.
- I cannot reproduce the issue on macOS 11.5. On Windows 10x64 the issue is not so visible. The issue is more visible on Ubuntu 20.04.
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
It's because of:
https://github.com/mozilla/pdf.js/commit/07cd7cb3dce4a4af1d555002486c15a5ed4b5302#diff-4748c83592581d85910b4a948677ddfcd25c8dc68ffcd20c524e0f4f0739f51aR92
Reverting the border to 1px
for choiceWidgetAnnotation
is fixing the issue.
Comment 2•2 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #1)
It's because of:
https://github.com/mozilla/pdf.js/commit/07cd7cb3dce4a4af1d555002486c15a5ed4b5302#diff-4748c83592581d85910b4a948677ddfcd25c8dc68ffcd20c524e0f4f0739f51aR92
Reverting the border to1px
forchoiceWidgetAnnotation
is fixing the issue.
Given that the border now takes up more space than before, should we perhaps reduce the font-size accordingly to compensate?
Assignee | ||
Comment 3•2 years ago
|
||
We should likely do something around:
https://github.com/mozilla/pdf.js/blob/master/src/display/annotation_layer.js#L986
Since it was ok for a border equals to 1px, likely removing 1 to the height should be enough.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Comment 5•2 years ago
|
||
Since this is reoccuring, we should try to add some kind of automated test.
Assignee | ||
Comment 6•2 years ago
|
||
We already have some tests for that, but the bug here depends of the default font used in the dropdown.
Reporter | ||
Comment 7•2 years ago
|
||
Verified fixed with Firefox 108.0a1 (2022-10-27) on Windows 10x64, macOS 12 and Ubuntu 20.04. The text is no longer clipped after following the steps from comment 0.
Updated•2 years ago
|
Description
•