Closed Bug 1793505 Opened 2 years ago Closed 2 years ago

Browser toolbox style editor content frame overflows

Categories

(DevTools :: Style Editor, defect)

defect

Tracking

(firefox-esr102 unaffected, firefox105 unaffected, firefox106 unaffected, firefox107 verified)

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- unaffected
firefox107 --- verified

People

(Reporter: aminomancer, Assigned: emilio, NeedInfo)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

If you open a browser toolbox > style editor > pick a really long stylesheet like browser.css, the stylesheet content's scrollbar overflows off the window, so you can't reach all the code.

Flags: needinfo?(emilio)

The Bugbug bot thinks this bug should belong to the 'DevTools::Style Editor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Style Editor

Set release status flags based on info from the regressing bug 1792473

Assignee: nobody → emilio
Flags: needinfo?(emilio)

Intrinsic sizing of scrollers affecting min-sizes of containing boxes is
one of those annoying behaviors of modern flexbox unfortunately, but
it's easy to fix using containment.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4156d542aed2
Prevent stylesheet media query list from affecting the minimum size of the style editor panel. r=devtools-reviewers,ochameau
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

== Change summary for alert #35638 (as of Fri, 07 Oct 2022 17:22:46 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
35% damp browser-toolbox.styleeditor-ready.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 468.55 -> 632.08
28% damp browser-toolbox.styleeditor-ready.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 455.81 -> 582.03
27% damp browser-toolbox.styleeditor-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 439.44 -> 558.77
23% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender 512.68 -> 632.26
23% damp browser-toolbox.styleeditor-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 437.61 -> 536.38
22% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 515.70 -> 630.31

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35638

Performance regressions on styleeditor browser toolbox tests.

Can you file a new bug for the perf regressions and ni? me? Happy to take a look.

Sure! Let me just verify the changesets first, because I can't reproduce the regression locally. This specific regression could also be from Bug 1793687.

Flags: needinfo?(jdescottes)
No longer blocks: 1794393
Regressions: 1794393
QA Whiteboard: [qa-107b-p2]
Regressions: 1796750

Reproduced the issue with Firefox 107.0a1 (2022-10-03) on Windows 10x64.
The issue is no longer reproducible with Firefox 107.0b6 on Windows 10x64, macOS 12 and Ubuntu 20.04. The stylesheet content's scrollbar no longer overflows off the window.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: