Closed Bug 1792818 Opened 2 years ago Closed 2 years ago

Login pop-up Windows are being picked up as the last active tab in Firefox View

Categories

(Firefox :: Firefox View, defect)

Desktop
All
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox105 --- affected
firefox106 --- affected
firefox107 --- affected

People

(Reporter: rdoghi, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

Attached image 2022-09-29_14h59_38.png

Found in

  • 106.0b5 (2022-09-28)

Affected versions

  • Firefox Nightly 107.0a1
  • Beta 106.0b5

Affected platforms

  • all

Steps to reproduce

  1. Sign in on Both Machines A and B.
  2. Reach Firefox View on Machine A.
  3. Reach pinterest.com on Machine B and select Login with Facebook in order to open the pop up window.
  4. Sync on both devices.
  5. Select the Last Active "facebook" page from the Tab Pickup section in Firefox View on Machine A.
  6. Sign in to Facebook with a valid account.

Expected result

  • Pop-up windows should not be displayed in the Tab pickup section.
  • Only The Pinterest tab should be displayed in the Tab pickup section.

Actual result

  • The Log in pop up window is displayed as the last active tab.
  • The user can select the Last Active tab on Machine A and reach the facebook login page.
  • Logging in to Facebook will immediately close the tab.
  • Clicking on the Last Active Tab again from the Firefox View page will open and close a new tab immediately.
Attached image 2022-09-29_15h00_02.png
Has STR: --- → yes

Gijs -- What do you think about this one? Are we able to detect pop up windows like this? This doesn't feel like a broken experience to me...but I can understand why this might be unexpected behavior.

Flags: needinfo?(gijskruitbosch+bugs)

I think this is probably more a question for the sync team. I'm guessing there's not a way to differentiate between a login tab and any other tab.

Flags: needinfo?(markh)

(In reply to Sarah Clements [:sclements] from comment #3)

I'm guessing there's not a way to differentiate between a login tab and any other tab.

This is the crux of the problem. We really can't reasonably detect whether a tab or a popup window is for a login. For sites that show a separate tab for a login (eg, some of our SSO logins do that), users probably also don't want that login tab to be the most recent tab either.

I'm quite sure we could choose to exclude all popup windows from the tab list, but the question is whether that's the correct thing to do in all cases? We will not be able to exclude only login popups and some sites show real content in these Windows (eg, until very recently, my bank insisted on opening the actual online banking page in such a popup)

I think this is a product decision rather than an engineering one.

Flags: needinfo?(markh)

Thanks for this context Mark. I feel that excluding all popup windows could potentially yield some edge cases that we may not actually want to exclude. I say we live with this issue for now and can further investigate exhaustive scenarios post MR.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Flags: needinfo?(gijskruitbosch+bugs)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: