Closed Bug 1792680 Opened 2 years ago Closed 2 years ago

The Reload button is not functional inside the Firefox View page

Categories

(Firefox :: Tabbed Browser, defect, P2)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- verified
firefox107 --- verified

People

(Reporter: asoncutean, Assigned: tgiles)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

Screencast issue
138.84 KB, application/octet-stream
Details
Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-release+
Details | Review
Attached file Screencast issue —

Found in

  • 106.0b5

Affected versions

  • 106.0b5
  • 107.0a1

Affected platforms

  • macOS 11, Windows 10, Ubuntu 20

Steps to reproduce

  1. Launch FF
  2. Open the Firefox View page by clicking the Firefox View toolbar button
  3. [Optional] - Open the Colorways modal
  4. Click the Reload button (or press CTL + R)

Expected result

  • The page is reloaded, the Colorways modal is dismissed.

Actual result

  • Nothing happens.

Regression range

Additional notes

  • If the page is opened with about:firefoxview, the reload button is working.
Has STR: --- → yes
Regressed by: 1790593

Set release status flags based on info from the regressing bug 1790593

:dao, since you are the author of the regressor, bug 1790593, could you take a look?

For more information, please visit auto_nag documentation.

status-firefox105: --- → unaffected
status-firefox-esr102: --- → unaffected
Flags: needinfo?(dao+bmo)
Whiteboard: [fidefe-2022-mr1-firefox-view]
Assignee: nobody → tgiles
Blocks: 1794474
Status: NEW → ASSIGNED
Priority: -- → P2
Flags: needinfo?(dao+bmo)
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd527f18b07c
Fix Firefox View not being a reloadable tab. r=dao

https://hg.mozilla.org/mozilla-central/rev/fd527f18b07c

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Verified fixed with Fx 107.0a1 (2022-10-14) on Windows 10, macOS 12 and Ubuntu 22.04

Status: RESOLVED → VERIFIED
status-firefox107: fixed → verified

Comment on attachment 9298280 [details]
Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao

Beta/Release Uplift Approval Request

  • User impact if declined: Needed dependency for the patch on bug 1794474.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: See STR for bug 1794474
  • List of other uplifts needed: Bug 1794474
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One line fix to logic that determines what constitutes a selectableTab. We have pretty good test coverage here and we've see no QA or contributor bugs filed
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9298280 - Flags: approval-mozilla-release?

Comment on attachment 9298280 [details]
Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao

Approved with Bug 1794474.

Attachment #9298280 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified fixed with Fx 106.0.2 on Windows 10, macOS 12 and Ubuntu 22.04.

status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: