Firefox closes when restoring the previous session from the "Show me how" button after the Firefox View tab was focused
Categories
(Firefox :: Firefox View, defect)
Tracking
()
People
(Reporter: Gabi, Assigned: niklas)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fidefe-2022-mr1-firefox-view])
Attachments
(2 files)
|
3.62 MB,
video/mp4
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Found in
- Firefox 106.0b4
Affected versions
- Firefox Nightly 107.0a1
- Firefox 106.0b4
Tested platforms
- Affected platforms: Windows 10x64, macOS 10.12.6, Ubuntu 22
- Unaffected platforms: -
Steps to reproduce
- Launch Firefox with a new profile
- Open a few tabs for history purposes
- Close Firefox
- Open Firefox with the same profile
- Focus the Firefox View tab
- Go to the other open tab to see the "restore previous session" message
- Click on "Show me how" button and restore the previous session
Expected result
- Firefox closes when restoring the previous session from the "Show me how" button after the Firefox View tab was focused
Actual result
- The previous session should be restored without any issues.
Regression range
- Most likely not a regression since issue is reproducible with Nightly 105.0a1
Additional notes
- See the attached screen recording
- Issue is not reproducible if the Firefox View tab was not selected before
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c91bf964f30f Keep window open when restoring with hidden tabs. r=Gijs
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9296413 [details]
Bug 1792441 - Keep window open when restoring with hidden tabs. r=gijs!,dao!
Beta/Release Uplift Approval Request
- User impact if declined: Windows closing willy-nilly when they shouldn't, manual session restore not working correctly
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: No
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Straightforward expansion of previous JS-only fix, has automated test
- String changes made/needed: No
- Is Android affected?: No
|
|
||
Updated•2 years ago
|
|
||
Comment 6•2 years ago
|
||
Comment on attachment 9296413 [details]
Bug 1792441 - Keep window open when restoring with hidden tabs. r=gijs!,dao!
Approved for 106.0b7, thanks.
|
|
||
Comment 7•2 years ago
|
||
| bugherder uplift | ||
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
Verified that the issue is fixed on Firefox 106.0b7 and 107.0a1. Tests were performed on macOS 13, Windows 11 and Ubuntu 22.04.
|
||
Comment 9•2 years ago
|
||
Perfherder has detected a talos performance improvement from either this or Bug 1792546. Do you believe this patch could have caused the following improvement?
== Change summary for alert #35617 (as of Tue, 04 Oct 2022 17:43:26 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 7% | perf_reftest_singletons id-getter-2.html | windows10-64-shippable-qr | e10s fission stylo webrender | 675.96 -> 629.55 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35617
|
|
Assignee | |
Comment 10•2 years ago
|
||
It doesn't seem likely that this patch caused the performance improvement
Description
•